Re: [Zope-CMF] [dev] working on the trunk
Hi Charlie! Charlie Clark wrote: I've hit a bit of a problem with folder syndication - I already have an annotations adapter for storing the values on the folder and I can extend this to be able to handle individual values rather than a dictionary but ProxyFieldProperties don't work because the adapter itself doesn't support properties. I also have some additional methods on the adapter that I use from the view. What do you think is the best way to proceed here? Subclass the SchemaAdapter so that the encoding and DateTime stuff works okay? For the methods I don't see any alternative but to expose the annotations adapter explicitly within the view. Bit of a muddle, I guess. If you want to modernize SyndicationInformation, why do you still store DateTime objects in the database? (And why don't you use zope.annotation?) Quoting the docstring of schema.py: SchemaAdapterBase and ProxyFieldProperty are legacy code. They should only be used to adapt old content types that can't handle unicode and datetime correctly. AFAICS only the getUpdateBase method of ISyndicationTool needs to be backwards compatible. Everything else is new API or doesn't return DateTime objects. Wouldn't it be better to use datetime internally? You already need an upgrade step for SyndicationInformation. Writing an additional upgrade step for SyndicationTool wouldn't be much extra work. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] [dev] working on the trunk
Hiya yuppie, Am 30.09.2011, 10:55 Uhr, schrieb yuppie y.2...@wcm-solutions.de: If you want to modernize SyndicationInformation, why do you still store DateTime objects in the database? (And why don't you use zope.annotation?) I think that when I started this I was initially trying to update the syndication stuff and practise writing tests by filling out the missing blanks. It then snowballed with my views work. You're right, of course, that having removing the ZMI interface to SyndicationInfo I've got more control over how stuff was stored. I need to revisit the zope.annotation docs but the last time I looked it didn't offer much. Quoting the docstring of schema.py: SchemaAdapterBase and ProxyFieldProperty are legacy code. They should only be used to adapt old content types that can't handle unicode and datetime correctly. What? You think I'm going to start reading the code? ;-) Having got Site Syndication licked I thought I could consolidate the view code. How wrong I was! AFAICS only the getUpdateBase method of ISyndicationTool needs to be backwards compatible. Everything else is new API or doesn't return DateTime objects. Wouldn't it be better to use datetime internally? You already need an upgrade step for SyndicationInformation. Writing an additional upgrade step for SyndicationTool wouldn't be much extra work. Right. BTW. anyone know of an OFS implementation of os.walk? There used to be zwalk but I think it's disappeared behind the Google horizon. Charlie -- Charlie Clark Managing Director Clark Consulting Research German Office Helmholtzstr. 20 Düsseldorf D- 40215 Tel: +49-211-600-3657 Mobile: +49-178-782-6226 ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
[Zope-CMF] cmf-tests - OK: 4
This is the summary for test reports received on the cmf-tests list between 2011-09-29 00:00:00 UTC and 2011-09-30 00:00:00 UTC: See the footnotes for test reports of unsuccessful builds. An up-to date view of the builders is also available in our buildbot documentation: http://docs.zope.org/zopetoolkit/process/buildbots.html#the-nightly-builds Reports received CMF-2.2 Zope-2.12 Python-2.6.6 : Linux CMF-2.2 Zope-2.13 Python-2.6.6 : Linux CMF-trunk Zope-2.13 Python-2.6.6 : Linux CMF-trunk Zope-trunk Python-2.6.6 : Linux Non-OK results -- ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
