[Zope-dev] Zope Tests: 5 OK

2008-08-12 Thread Zope Tests Summarizer
Summary of messages to the zope-tests list.
Period Mon Aug 11 11:00:00 2008 UTC to Tue Aug 12 11:00:00 2008 UTC.
There were 5 messages: 5 from Zope Tests.


Tests passed OK
---

Subject: OK : Zope-2.8 Python-2.3.6 : Linux
From: Zope Tests
Date: Mon Aug 11 20:51:48 EDT 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-August/009995.html

Subject: OK : Zope-2.9 Python-2.4.4 : Linux
From: Zope Tests
Date: Mon Aug 11 20:53:18 EDT 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-August/009996.html

Subject: OK : Zope-2.10 Python-2.4.4 : Linux
From: Zope Tests
Date: Mon Aug 11 20:54:49 EDT 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-August/009997.html

Subject: OK : Zope-2.11 Python-2.4.4 : Linux
From: Zope Tests
Date: Mon Aug 11 20:56:23 EDT 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-August/009998.html

Subject: OK : Zope-trunk Python-2.4.4 : Linux
From: Zope Tests
Date: Mon Aug 11 20:57:53 EDT 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-August/00.html

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope.app.form: Make no value always available?

2008-08-12 Thread Thomas Lotze
zope.app.form items edit widgets don't provide the no value value if
the corresponding field is required. While this prevents invalid input, it
means that e.g. a drop-down box may then have one of the valid values
pre-selected. If user forgets to change that value, he could save the form
without noticing that the default value is implicitly selected, which may
be completely wrong.

In some cases it would be preferrable for the widget to default to a no
value value even if the field is required so the form won't validate if
the user doesn't consciously select a value. One of our customers asked
for this behaviour, for example. If noone objects, we'd like to change
zope.app.form accordingly.

-- 
Thomas Lotze · [EMAIL PROTECTED]
gocept gmbh  co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
Zope and Plone consulting and development

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.form: Make no value always available?

2008-08-12 Thread Philipp von Weitershausen
Thomas Lotze wrote:
 zope.app.form items edit widgets don't provide the no value value if
 the corresponding field is required. While this prevents invalid input, it
 means that e.g. a drop-down box may then have one of the valid values
 pre-selected. If user forgets to change that value, he could save the form
 without noticing that the default value is implicitly selected, which may
 be completely wrong.
 
 In some cases it would be preferrable for the widget to default to a no
 value value even if the field is required so the form won't validate if
 the user doesn't consciously select a value. One of our customers asked
 for this behaviour, for example. If noone objects, we'd like to change
 zope.app.form accordingly.

+1, but perhaps for required fields we shouldn't say (no value), we 
should say (select a value).
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.form: Make no value always available?

2008-08-12 Thread Roger Ineichen
Hi Thomas
 
 Betreff: [Zope-dev] zope.app.form: Make no value always available?
 
 zope.app.form items edit widgets don't provide the no value 
 value if the corresponding field is required. While this 
 prevents invalid input, it means that e.g. a drop-down box 
 may then have one of the valid values pre-selected. If user 
 forgets to change that value, he could save the form without 
 noticing that the default value is implicitly selected, which 
 may be completely wrong.
 
 In some cases it would be preferrable for the widget to 
 default to a no value value even if the field is required 
 so the form won't validate if the user doesn't consciously 
 select a value. One of our customers asked for this 
 behaviour, for example. If noone objects, we'd like to change 
 zope.app.form accordingly.

I agree with this but...
The 2750 test in one of our well tested application will explode.
And probably some tests in the zope core and z3c will break too.

Since this is a miss behavior and I agree that this should get 
fixed. We probably should think about a solution which supports
the old behavior by default.

Note, this whould probably also break other packages like 
z3c.csvvocabulary.

If nobody else objects I'm fine with this changes and will fix a 
Zope3 revision for this project and start to migrate to z3c.form.
We have to do that anyway sometimes.

In general, this is not a bug it's just a bad behavior.

What do you think?

Regards
Roger Ineichen

 --
 Thomas Lotze · [EMAIL PROTECTED]
 gocept gmbh  co. kg · forsterstraße 29 · 06112 halle (saale) 
 · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 
 345 1229889 1 Zope and Plone consulting and development
 
 ___
 Zope-Dev maillist  -  Zope-Dev@zope.org
 http://mail.zope.org/mailman/listinfo/zope-dev
 **  No cross posts or HTML encoding!  ** (Related lists -  
 http://mail.zope.org/mailman/listinfo/zope-announce
  http://mail.zope.org/mailman/listinfo/zope )
 

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.form: Make no value always available?

2008-08-12 Thread Thomas Lotze
Roger Ineichen wrote:

 I agree with this but...
 The 2750 test in one of our well tested application will explode. And
 probably some tests in the zope core and z3c will break too.
 
 Since this is a miss behavior and I agree that this should get fixed. We
 probably should think about a solution which supports the old behavior by
 default.

Fine with me.

 If nobody else objects I'm fine with this changes and will fix a Zope3
 revision for this project and start to migrate to z3c.form. We have to do
 that anyway sometimes.

I don't understand what you're saying here. Are you talking about that
application of yours that you've refered to earlier? Who has to migrate to
z3c.form, and how does this affect the development of zope.app.form?

-- 
Thomas Lotze · [EMAIL PROTECTED]
gocept gmbh  co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
Zope and Plone consulting and development


___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.form: Make no value always available?

2008-08-12 Thread Roger Ineichen
Hi Thomas

 Betreff: Re: [Zope-dev] zope.app.form: Make no value always 
 available?

[...]

  If nobody else objects I'm fine with this changes and will 
 fix a Zope3 
  revision for this project and start to migrate to z3c.form. 
 We have to 
  do that anyway sometimes.
 
 I don't understand what you're saying here. Are you talking 
 about that application of yours that you've refered to 
 earlier? Who has to migrate to z3c.form, and how does this 
 affect the development of zope.app.form?

Sorry for confusing you. Yes I was talking about our application.

Regards
Roger Ineichen
_
END OF MESSAGE

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope.testrunner test failures on windows

2008-08-12 Thread Chris Withers
Hi All,

I could have sworn I reported this before but couldn't find anything in 
the archives so apologies if I have posted this before...

Anyway, running zope.testrunner's trunk's tests on windows seems to have 
some problems. These don't occur when running them on Linux.

cheers,

Chris

The output:


  bin\test.exe
Running zope.testing.testrunner.layer.UnitTests tests:
   Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds.


Failure in test zope.testing\src\zope\testing\testrunner\testrunner-
debugging-layer-setup.test
Failed doctest test for testrunner-debugging-layer-setup.test
   File zope.testing\src\zope\testing\testrunner\testrunner-debuggin
g-layer-setup.test, line 0

--
File zope.testing\src\zope\testing\testrunner\testrunner-debugging-
layer-setup.test, line 45, in testrunner-debugging-layer-setup.test
Failed example:
 try:
 zope.testing.testrunner.run(['--path', dir, '-D'])
 finally: sys.stdin = real_stdin
 # doctest: +ELLIPSIS
Exception raised:
 Traceback (most recent call last):
   File zope.testing\src\zope\testing\doctest.py, line 1356, in
  __run
 compileflags, 1) in test.globs
   File doctest testrunner-debugging-layer-setup.test[10], line 
2, in ?
   File zope.testing\src\zope\testing\testrunner\__init__.py, l
ine 33, in run
 runner.run()
   File zope.testing\src\zope\testing\testrunner\runner.py, lin
e 129, in run
 feature.global_setup()
   File zope.testing\src\zope\testing\testrunner\find.py, line
343, in global_setup
 tests = find_tests(self.runner.options, self.runner.found_suites)
   File zope.testing\src\zope\testing\testrunner\find.py, line
53, in find_tests
 for suite in found_suites:
   File zope.testing\src\zope\testing\testrunner\find.py, line
103, in find_suites
 suite = StartUpFailure(
   File zope.testing\src\zope\testing\testrunner\find.py, line
36, in __init__
 post_mortem(exc_info)
   File zope.testing\src\zope\testing\testrunner\runner.py, lin
e 717, in post_mortem
 pdb.post_mortem(exc_info[2])
   File Python24\lib\pdb.py, line 1016, in post_mortem
 while t.tb_next is not None:
 AttributeError: 'NoneType' object has no attribute 'tb_next'

A message on stderr.  Please ignore (expected in test output).


Failure in test zope.testing\src\zope\testing\testrunner\testrunner-
coverage-win32.txt
Failed doctest test for testrunner-coverage-win32.txt
   File zope.testing\src\zope\testing\testrunner\testrunner-coverage
-win32.txt, line 0

--
File zope.testing\src\zope\testing\testrunner\testrunner-coverage-w
in32.txt, line 14, in testrunner-coverage-win32.txt
Failed example:
 ignore = testrunner.TestIgnore(WinOptions())
Exception raised:
 Traceback (most recent call last):
   File zope.testing\src\zope\testing\doctest.py, line 1356, in
  __run
 compileflags, 1) in test.globs
   File doctest testrunner-coverage-win32.txt[2], line 1, in ?
 AttributeError: 'module' object has no attribute 'TestIgnore'
--
File zope.testing\src\zope\testing\testrunner\testrunner-coverage-w
in32.txt, line 15, in testrunner-coverage-win32.txt
Failed example:
 ignore._test_dirs
Exception raised:
 Traceback (most recent call last):
   File zope.testing\src\zope\testing\doctest.py, line 1356, in
  __run
 compileflags, 1) in test.globs
   File doctest testrunner-coverage-win32.txt[3], line 1, in ?
 NameError: name 'ignore' is not defined
--
File zope.testing\src\zope\testing\testrunner\testrunner-coverage-w
in32.txt, line 20, in testrunner-coverage-win32.txt
Failed example:
 ignore.names('r:\\winproject\\src\\blah\\foo\\baz.py', 'baz')
Exception raised:
 Traceback (most recent call last):
   File zope.testing\src\zope\testing\doctest.py, line 1356, in
  __run
 compileflags, 1) in test.globs
   File doctest testrunner-coverage-win32.txt[4], line 1, in ?
 NameError: name 'ignore' is not defined
--
File zope.testing\src\zope\testing\testrunner\testrunner-coverage-w
in32.txt, line 22, in testrunner-coverage-win32.txt
Failed example:
 ignore.names('R:\\winproject\\src\\blah\\foo\\baz.py', 'baz')
Exception raised:
 Traceback (most recent call last):
   File zope.testing\src\zope\testing\doctest.py, line 1356, in
  __run
 compileflags, 1) in test.globs
   File doctest testrunner-coverage-win32.txt[5], line 1, in ?
 NameError: name 'ignore' is not defined
--
File zope.testing\src\zope\testing\testrunner\testrunner-coverage-w
in32.txt, line 24, in