Re: [Zope-dev] zope.pluggableauth and camefrom information in login form not an absolute URL

2011-02-08 Thread Jan-Wijbrand Kolman
On 2/7/11 18:03 PM, Roger wrote:
 why not use the same pattern like I changed to in z3c.authenticator.
 There the camefrom request part was replaced by session handling.

 On the other side, I think your changes are fine since, I guess
 someone from gocept, a long time ago, fixed and protected the
 redirect method.

Ok, thanks for your feedback!

I applied the patch, added a test just to show a redirect to a 
suspicious URL will by default not work and released zope.pluggableauth 1.3

regards, jw

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Zope Tests: 81 OK, 18 Failed

2011-02-08 Thread Zope Tests Summarizer
Summary of messages to the zope-tests list.
Period Mon Feb  7 12:00:00 2011 UTC to Tue Feb  8 12:00:00 2011 UTC.
There were 99 messages: 8 from Zope Tests, 4 from buildbot at pov.lt, 31 from 
buildbot at winbot.zope.org, 11 from ccomb at free.fr, 45 from jdriessen at 
thehealthagency.com.


Test failures
-

Subject: FAILED : Zope Buildbot / zope2.14-py2.6 slave-ubuntu64
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:05:10 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031281.html

Subject: FAILED : Zope Buildbot / zope2.13_win-py2.6 slave-win
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:17:33 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031284.html

Subject: FAILED : Zope Buildbot / zope2.13_win-py2.7 slave-win
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:19:08 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031286.html

Subject: FAILED : Zope Buildbot / zopetoolkit-1.1_win-py2.6 slave-win
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 15:16:43 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031296.html

Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.6 slave-win
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 15:32:35 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031300.html

Subject: FAILED : winbot / ztk_10 py_244_win32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 16:02:49 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031304.html

Subject: FAILED : winbot / z3c.form_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 22:20:02 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031354.html

Subject: FAILED : winbot / z3c.rml_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 22:44:53 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031355.html

Subject: FAILED : winbot / z3c.template_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 22:53:34 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031356.html

Subject: FAILED : winbot / z3c.layer.ready2go_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 22:59:01 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031357.html

Subject: FAILED : winbot / z3c.formui_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:00:24 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031358.html

Subject: FAILED : winbot / z3c.tabular_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:02:35 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031360.html

Subject: FAILED : winbot / z3c.contents_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:03:37 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031361.html

Subject: FAILED : winbot / z3c.ptcompat_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:23:16 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031362.html

Subject: FAILED : winbot / z3c.pdftemplate_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:27:49 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031363.html

Subject: FAILED : winbot / z3c.coverage_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:29:17 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031364.html

Subject: FAILED : winbot / z3c.macro_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:30:04 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031365.html

Subject: FAILED : winbot / z3c.pagelet_py_265_32
From: buildbot at winbot.zope.org
Date: Mon Feb  7 23:35:11 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031366.html


Tests passed OK
---

Subject: OK : Zope Buildbot / zope2.12-py2.6 slave-ubuntu64
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:01:50 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031278.html

Subject: OK : Zope Buildbot / zope2.13-py2.6 slave-ubuntu64
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:03:17 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031279.html

Subject: OK : Zope Buildbot / zope2.13-py2.7 slave-ubuntu64
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:04:44 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031280.html

Subject: OK : Zope Buildbot / zope2.14-py2.7 slave-ubuntu64
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:06:43 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031282.html

Subject: OK : Zope Buildbot / zopetoolkit-1.0-py2.4 slave-ubuntu64
From: jdriessen at thehealthagency.com
Date: Mon Feb  7 14:12:24 EST 2011
URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031283.html

Subject: OK : Zope Buildbot / 

Re: [Zope-dev] Zope Tests: 81 OK, 18 Failed

2011-02-08 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 02/08/2011 06:58 AM, Zope Tests Summarizer wrote:
 Summary of messages to the zope-tests list.
 Period Mon Feb  7 12:00:00 2011 UTC to Tue Feb  8 12:00:00 2011 UTC.
 There were 99 messages: 8 from Zope Tests, 4 from buildbot at pov.lt, 31 from 
 buildbot at winbot.zope.org, 11 from ccomb at free.fr, 45 from jdriessen at 
 thehealthagency.com.
 
 
 Test failures
 -
 
 Subject: FAILED : Zope Buildbot / zope2.14-py2.6 slave-ubuntu64
 From: jdriessen at thehealthagency.com
 Date: Mon Feb  7 14:05:10 EST 2011
 URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031281.html
 
 Subject: FAILED : Zope Buildbot / zope2.13_win-py2.6 slave-win
 From: jdriessen at thehealthagency.com
 Date: Mon Feb  7 14:17:33 EST 2011
 URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031284.html
 
 Subject: FAILED : Zope Buildbot / zope2.13_win-py2.7 slave-win
 From: jdriessen at thehealthagency.com
 Date: Mon Feb  7 14:19:08 EST 2011
 URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031286.html
 
 Subject: FAILED : Zope Buildbot / zopetoolkit-1.1_win-py2.6 slave-win
 From: jdriessen at thehealthagency.com
 Date: Mon Feb  7 15:16:43 EST 2011
 URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031296.html
 
 Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.6 slave-win
 From: jdriessen at thehealthagency.com
 Date: Mon Feb  7 15:32:35 EST 2011
 URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031300.html

I can't get to the buildbot pages for any of these failures.  Jan-Jaap,
can you investigate?

 Subject: FAILED : winbot / ztk_10 py_244_win32
 From: buildbot at winbot.zope.org
 Date: Mon Feb  7 16:02:49 EST 2011
 URL: http://mail.zope.org/pipermail/zope-tests/2011-February/031304.html

I just dumped the expected and got values to files and diffed them
(why doesn't doctest show diff output by default?).  It looks as though
the 'samplelayers.layer122' tests are being skipped for some reason::

- - % ---
 $ diff -u /tmp/expected.txt /tmp/got.txt
 --- /tmp/expected.txt  2011-02-08 11:31:44.814287122 -0500
 +++ /tmp/got.txt   2011-02-08 11:32:02.390287290 -0500
 @@ -46,15 +46,6 @@
Tear down samplelayers.Layer121 in N.NNN seconds.
Tear down samplelayers.Layer12 in N.NNN seconds.
Tear down samplelayers.Layer1 in N.NNN seconds.
 -Running samplelayers.Layer122 tests:
 -  Running in a subprocess.
 -  Set up samplelayers.Layer1 in N.NNN seconds.
 -  Set up samplelayers.Layer12 in N.NNN seconds.
 -  Set up samplelayers.Layer122 in N.NNN seconds.
 -  Ran 34 tests with 0 failures and 0 errors in N.NNN seconds.
 -  Tear down samplelayers.Layer122 in N.NNN seconds.
 -  Tear down samplelayers.Layer12 in N.NNN seconds.
 -  Tear down samplelayers.Layer1 in N.NNN seconds.
  Running zope.testing.testrunner.layer.UnitTests tests:
Running in a subprocess.
Set up zope.testing.testrunner.layer.UnitTests in N.NNN seconds.
 @@ -62,5 +53,5 @@
Tear down zope.testing.testrunner.layer.UnitTests in N.NNN seconds.
  Tearing down left over layers:
Tear down samplelayers.Layer1 in N.NNN seconds.
 -Total: 405 tests, 0 failures, 0 errors in N.NNN seconds.
 +Total: 371 tests, 0 failures, 0 errors in N.NNN seconds.
  False
- - % ---



- -- 
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   Excellence by Designhttp://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1RcPwACgkQ+gerLs4ltQ4DAwCdGbfjWUkrWP9grJvmvUu2Ia2s
sfcAoJ+hS/JRvg17c6r6TbKMidi2DcLz
=Ep+f
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )