Re: [Zope-dev] zope-tests - FAILED: 4, OK: 8
On Tue, Sep 10, 2013 at 09:49:50AM +0200, Brian Sutherland wrote: On Tue, Sep 10, 2013 at 09:32:18AM +0300, Marius Gedminas wrote: IIRC there's a brand new zope.testbrowser 4.1.0 with Python 3 support, built on top of WebTest, waiting in the py3 branch for... Actually, I'm not sure what it is waiting for. (I thought ZODB with Python 3 support, but it doesn't look like zope.testbrowser depends on ZODB, at least not directly.) Indeed, and it's had no changes for at least 5 months and been tested with a few existing codebases. +1 for releasing it One tests fails in the py3 branch: test_strip_linebreaks_from_textarea. It tests that if you inspect getControl(name='textarea').value, you'll see one initial '\n' stripped away. This fails when the textarea in question has two initial newlines: textarea Foo /textarea The test expects .value to be '\nFoo\n', but it actually gets 'Foo\n'. This test was added by Benji York in 2006 (commit 4545f144) and refers to issue 644 in some unspecified bug tracker. Google allowed me to find a copy of the issue in question: https://bugs.launchpad.net/zope3/+bug/98371 In particular the following comment is interesting: We've verified that browsers (we tested Firefox, Mozilla, Safari, and IE) will strip a single leading newline (crlf) if it is at the beginning of the string. -- Jim Fulton, https://bugs.launchpad.net/zope3/+bug/98371/comments/12 It was serious enough to warrant changes to the local copy of ClientForm (and an upstream submission of the patch). It looks like what happened here was that WebTest itself was modified to eat the first newline in a textarea: https://github.com/Pylons/webtest/pull/69 so now we eat two. This change was released in WebTest 2.0.6: http://webtest.pythonpaste.org/en/latest/changelog.html#id2 I guess what we have to do is remove the 1st newline stripping logic from zope.testbrowser and require WebTest = 2.0.6. Ok, fixed. Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope-tests - FAILED: 4, OK: 8
On Tue, Sep 10, 2013 at 09:32:18AM +0300, Marius Gedminas wrote:
IIRC there's a brand new zope.testbrowser 4.1.0 with Python 3 support,
built on top of WebTest, waiting in the py3 branch for... Actually, I'm
not sure what it is waiting for. (I thought ZODB with Python 3 support,
but it doesn't look like zope.testbrowser depends on ZODB, at least not
directly.)
I think I remembered now: a WebTest release with some bugfixes.
I'm trying to merge the py3 branch to master now. There's one issue:
the test for https://github.com/zopefoundation/zope.testbrowser/pull/4
uses the internal .mech_browser attribute.
I think what is actually wanted here is a new API:
browser.handleRedirects = False
browser.open(...) # or browser.submit()
assert browser.getHeaders('Status') == '302 Found'
Comments?
Marius Gedminas
--
http://pov.lt/ -- Zope 3/BlueBream consulting and development
signature.asc
Description: Digital signature
___
Zope-Dev maillist - Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope-tests - FAILED: 4, OK: 8
On Thursday, September 12, 2013 11:38:16 AM Marius Gedminas wrote:
m trying to merge the py3 branch to master now. There's one issue:
the test for https://github.com/zopefoundation/zope.testbrowser/pull/4
uses the internal .mech_browser attribute.
I think what is actually wanted here is a new API:
browser.handleRedirects = False
browser.open(...) # or browser.submit()
assert browser.getHeaders('Status') == '302 Found'
Comments?
+1 That looks good.
Regards,
Stephan
--
Entrepreneur and Software Geek
Google me. Zope Stephan Richter
___
Zope-Dev maillist - Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] zope-tests - FAILED: 12, OK: 8
This is the summary for test reports received on the zope-tests list between 2013-09-11 00:00:00 UTC and 2013-09-12 00:00:00 UTC: See the footnotes for test reports of unsuccessful builds. An up-to date view of the builders is also available in our buildbot documentation: http://docs.zope.org/zopetoolkit/process/buildbots.html#the-nightly-builds Reports received [1]winbot / z3c.ptcompat_py_265_32 [2]winbot / zope.app.authentication_py_265_32 [3]winbot / zope.app.http_py_265_32 [4]winbot / zope.app.publication_py_265_32 [5]winbot / zope.app.publisher_py_265_32 [6]winbot / zope.app.security_py_265_32 [7]winbot / zope.app.session_py_265_32 [8]winbot / zope.app.wsgi_py_265_32 [9]winbot / zope.catalog_py_265_32 [10] winbot / zope.exceptions_py_265_32 [11] winbot / zope.session_py_265_32 [12] winbot / zope.viewlet_py_265_32 winbot / ztk_10 py_254_win32 winbot / ztk_10 py_265_win32 winbot / ztk_10 py_265_win64 winbot / ztk_11 py_254_win32 winbot / ztk_11 py_265_win32 winbot / ztk_11 py_265_win64 winbot / ztk_11 py_270_win32 winbot / ztk_11 py_270_win64 Non-OK results -- [1]FAILED winbot / z3c.ptcompat_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078710.html [2]FAILED winbot / zope.app.authentication_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078701.html [3]FAILED winbot / zope.app.http_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078702.html [4]FAILED winbot / zope.app.publication_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078700.html [5]FAILED winbot / zope.app.publisher_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078704.html [6]FAILED winbot / zope.app.security_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078707.html [7]FAILED winbot / zope.app.session_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078708.html [8]FAILED winbot / zope.app.wsgi_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078703.html [9]FAILED winbot / zope.catalog_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078709.html [10] FAILED winbot / zope.exceptions_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078711.html [11] FAILED winbot / zope.session_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078706.html [12] FAILED winbot / zope.viewlet_py_265_32 https://mail.zope.org/pipermail/zope-tests/2013-September/078705.html ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
