[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
Validation queue job zorba-windows-fixes-2012-12-21T01-39-39.389Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/zorba-windows-fixes-2012-12-21T01-39-39.389Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
Cosmic rays, trying again. -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job zorba-windows-fixes-2012-12-21T01-26-47.297Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/zorba-windows-fixes-2012-12-21T01-26-47.297Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba has been updated. Commit Message changed to: Fixes for Windows and VC++ 2010 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba
Luis Rodriguez Gonzalez has proposed merging
lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba.
Requested reviews:
Rodolfo Ochoa (rodolfo-ochoa)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005
- Fixes for Windows and VC++ 2010
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/compiler/rewriter/tools/dataflow_annotations.cpp'
--- src/compiler/rewriter/tools/dataflow_annotations.cpp 2012-12-06 22:49:35 +
+++ src/compiler/rewriter/tools/dataflow_annotations.cpp 2012-12-20 22:25:25 +
@@ -919,7 +919,7 @@
case var_expr::arg_var:
{
- theVarSourcesMap.insert(VarSourcesPair(e, NULL));
+ theVarSourcesMap.insert(VarSourcesPair(e, nullptr));
return;
}
=== modified file 'src/zorbautils/hashmap.h'
--- src/zorbautils/hashmap.h 2012-10-29 12:37:50 +
+++ src/zorbautils/hashmap.h 2012-12-20 22:25:25 +
@@ -513,9 +513,9 @@
csize n = theHashTab.size();
HashEntry* entry = &theHashTab[0];
- HashEntry* lastentry = &theHashTab[n];
+ HashEntry* lastentry = &theHashTab[n-1];
- for (; entry < lastentry; ++entry)
+ for (; entry <= lastentry; ++entry)
{
if (!entry->isFree())
entry->setFree();
@@ -1065,10 +1065,10 @@
HashEntry* entry;
HashEntry* oldentry = &oldTab[0];
- HashEntry* lastentry = &oldTab[oldcap];
+ HashEntry* lastentry = &oldTab[oldcap-1];
// Now rehash every entry
- for (; oldentry < lastentry; ++oldentry)
+ for (; oldentry <= lastentry; ++oldentry)
{
if (oldentry->isFree())
continue;
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-error_printer_in_api into lp:zorba
I've done a lot of clean-up. You have the basic implementation correct. I've moved several functions inline. I've moved the printing of the stack trace constants to XQueryException since only XQueryException has stack traces. I've added doxygen comments that you didn't. Why don't you include the "raised at" in the XML format? Why don't you include the "applied at" in the XML format? (Not knowing what it is is not an acceptable reason.) Why does ErrorPrinter need to exist at all? It seems redundant. -- https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
