[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread Rodolfo Ochoa
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug1025445 into 
lp:zorba.

Requested reviews:
  Rodolfo Ochoa (rodolfo-ochoa)
  Chris Hillery (ceejatec)
Related bugs:
  Bug #1025445 in Zorba: execinfo.h broke Windows build
  https://bugs.launchpad.net/zorba/+bug/1025445

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239

Disabling print stack trace for windows
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/store/naive/item.cpp'
--- src/store/naive/item.cpp	2012-07-12 17:29:55 +
+++ src/store/naive/item.cpp	2012-07-16 22:25:21 +
@@ -34,8 +34,10 @@
 
 #include runtime/function_item/function_item.h
 
-# include cstdlib
-# include execinfo.h
+#include cstdlib
+#ifndef WIN32
+#include execinfo.h
+#endif
 
 
 namespace zorba
@@ -495,6 +497,7 @@
 }
 
 
+#ifndef WIN32
 static void print_stack_trace( std::ostream o ) 
 {
   int BUF_SIZE = 250;
@@ -514,7 +517,7 @@
 o  allocation of backtrace symbols failed  std::endl;
   }
 }
-
+#endif
 
 /**
  * Accessor for xs:untypedAtomic and xs:string and its subtypes
@@ -536,8 +539,9 @@
 std::cerr  ???  std::endl;
   }
 
-  
+#ifndef WIN32
   print_stack_trace(std::cerr);
+#endif
 
   throw ZORBA_EXCEPTION(
 zerr::ZSTR0040_TYPE_ERROR,

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread Rodolfo Ochoa
The proposal to merge lp:~zorba-coders/zorba/bug1025445 into lp:zorba has been 
updated.

Commit Message changed to:

Disabling print stack trace for windows

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread Rodolfo Ochoa
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1025445 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug1025445-2012-07-16T23-47-55.546Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread Zorba Build Bot
Validation queue job bug1025445-2012-07-16T23-47-55.546Z is finished. The final 
status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1025445 into lp:zorba

2012-07-16 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug1025445 into lp:zorba has been 
updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1025445/+merge/115239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp