Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/core_archive_module into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/core_archive_module/+merge/112661 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/core_archive_module into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/core_archive_module/+merge/112661 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/core_archive_module into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/core_archive_module/+merge/112661 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/core_archive_module into lp:zorba
Matthias - we worked on something recently (I can't remember exactly what) which also involved a function to mark whether a stream was seekable or not. In particular, I asked for the comment to define clearly what seekable meant - does it mean arbitrarily seekable, or just restartable, or forward-seekable only, or what. Do you remember where that code was? At any rate, I would make the same request here - seekable is not IMHO sufficiently explicit. Other than that it looks good. That was in include/zorba/uri_resolver.h. I have committed a fix by improving the documentation the same way we did for the URI Resolvers. -- https://code.launchpad.net/~zorba-coders/zorba/core_archive_module/+merge/112661 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
