Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_1187807-2013-06-12T08-06-04.45Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba
Validation queue job fix_bug_1187807-2013-06-12T08-06-04.45Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187807/+merge/168681 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1189996-2013-06-12T12-36-56.857Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1189996-2013-06-12T12-36-56.857Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1189996-2013-06-12T13-24-03.998Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1189996-2013-06-12T13-24-03.998Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1189996-2013-06-12T13-39-59.374Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1189996-2013-06-12T13-39-59.374Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1189996-2013-06-12T14-05-06.022Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1189996-2013-06-12T14-05-06.022Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1189996-2013-06-12T14-29-54.488Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module. Commit message: fix build Requested reviews: Matthias Brantner (matthias-brantner) Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. === modified file 'include/tables.h' --- include/tables.h 2013-06-11 20:39:07 + +++ include/tables.h 2013-06-12 14:36:31 + @@ -35,21 +35,14 @@ XmlDataManager* theDataManager; public: -TablesFunction(const ExternalModule* aModule) : - theModule(aModule), - theFactory(Zorba::getInstance(0)->getItemFactory()), - theDataManager(Zorba::getInstance(0)->getXmlDataManager()) -{} +TablesFunction(const ExternalModule* aModule); -~TablesFunction() -{} +virtual ~TablesFunction(); public: -virtual String getURI() const -{ return theModule->getURI(); } +virtual String getURI() const; -virtual String getLocalName() const -{ return "tables"; } +virtual String getLocalName() const; virtual ItemSequence_t evaluate(const ExternalFunction::Arguments_t& args, @@ -57,7 +50,4 @@ const zorba::DynamicContext*) const; }; - - -}}; // namespace zorba, jdbc - +}} // namespace zorba, jdbc === modified file 'src/jdbc.xq.src/connection/tables.cpp' --- src/jdbc.xq.src/connection/tables.cpp 2013-06-11 20:39:07 + +++ src/jdbc.xq.src/connection/tables.cpp 2013-06-12 14:36:31 + @@ -23,6 +23,27 @@ namespace jdbc { +TablesFunction::TablesFunction(const ExternalModule* aModule) + : theModule(aModule), +theFactory(Zorba::getInstance(0)->getItemFactory()), +theDataManager(Zorba::getInstance(0)->getXmlDataManager()) +{} + +TablesFunction::~TablesFunction() +{} + +String +TablesFunction::getURI() const +{ + return theModule->getURI(); +} + +String +TablesFunction::getLocalName() const +{ + return "tables"; +} + ItemSequence_t TablesFunction::evaluate(const ExternalFunction::Arguments_t& args, const zorba::StaticContext* aStaticContext, -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
Review: Needs Information While moving the virtual functions out-of-line is good, it should have still linked with them inline. Hence, it's not clear that simply moving them out-of-line will fix the linking issue. Are you sure it fixes it? -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1189996-2013-06-12T14-29-54.488Z is finished. The final status was: 9 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
Review: Approve Well, it's better. We'll see if it fixes it. -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
The proposal to merge lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-jdbc-tables-2013-06-12T14-54-49.928Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
> While moving the virtual functions out-of-line is good, it should have still > linked with them inline. Hence, it's not clear that simply moving them > out-of-line will fix the linking issue. Are you sure it fixes it? No because I can't reproduce the problem. That's why I asked you to review. Matthias > -- > https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 > You proposed lp:~zorba-coders/zorba/feature-jdbc-tables for merging. -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
Validation queue job feature-jdbc-tables-2013-06-12T14-54-49.928Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module
The proposal to merge lp:~zorba-coders/zorba/feature-jdbc-tables into lp:zorba/jdbc-module has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 -- https://code.launchpad.net/~zorba-coders/zorba/feature-jdbc-tables/+merge/168965 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba. Commit message: Made base-name/dir-name "external," hence implemented in C++ rather than XQuery. The C++ implementation is trivial and the XQuery implementation was dozens of lines. The XQuery implementation hangs (after fs_util merge) for some bizarre reason and it's not worth debugging when the C++ implementation is much better. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Made base-name/dir-name "external," hence implemented in C++ rather than XQuery. The C++ implementation is trivial and the XQuery implementation was dozens of lines. The XQuery implementation hangs (after fs_util merge) for some bizarre reason and it's not worth debugging when the C++ implementation is much better. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'ChangeLog' --- ChangeLog 2013-06-11 23:35:24 + +++ ChangeLog 2013-06-12 15:40:46 + @@ -22,6 +22,7 @@ * Fixed bug #1188084 (fn-replace-42 failing) * Fixed bug in hoisting through try-catch expr * Fixed bug #1162631 (format-integer 'w' format of negative numbers) + * Fixed bug #1190261 (relative paths bug in file module) * Fixed bug #1180220 (Consolidate redundant path/file public APIs) * Fixed bug #1103115 (Timezone units as hours are wrong) * Fixed implementation of fn:deep-equal according to latest W3C spec. === modified file 'modules/org/expath/ns/file.xq' --- modules/org/expath/ns/file.xq 2013-06-06 20:56:08 + +++ modules/org/expath/ns/file.xq 2013-06-12 15:40:46 + @@ -751,29 +751,7 @@ : @param $path A file path/URI. : @return The base name of this file. :) -declare function file:base-name($path as xs:string) as xs:string -{ - let $delim := file:directory-separator() - let $escapedDelim := -if ($delim eq "/") then - $delim -else - fn:concat("\", $delim) - let $normalized-file := -let $n := file:prepare-for-dirname-and-base-name($path) -return if ($delim eq "\" and fn:matches($n, "^[a-zA-Z]:$")) then - fn:concat($n, "\") -else $n - return -if (fn:matches($path, fn:concat("^", $escapedDelim, "+$"))) then - "" -else if ($delim eq "\" and fn:matches($path, "^[a-zA-Z]:\\?$")) then - "" -else if ($path eq "") then - "." -else - fn:replace($normalized-file, fn:concat("^.*", $escapedDelim), "") -}; +declare function file:base-name($path as xs:string) as xs:string external; (:~ : Returns the last component from the $path, deleting any @@ -812,50 +790,6 @@ : @param $path The filename, of which the dirname should be get. : @return The name of the directory the file is in. :) -declare function file:dir-name($path as xs:string) as xs:string -{ - let $delim := file:directory-separator() - let $escapedDelim := -if ($delim eq "/") then - $delim -else - fn:concat("\", $delim) - let $normalized-file := file:prepare-for-dirname-and-base-name($path) - return -if (fn:matches($path, fn:concat("^", $escapedDelim, "+$"))) then - $delim -else if ($normalized-file eq $delim) then - $delim -else if ($delim eq "\" and fn:matches($path, "^[a-zA-Z]:\\$")) then - $path -else if ($delim eq "\" and fn:matches($normalized-file, "^[a-zA-Z]:$")) then - fn:concat($normalized-file, '\') -else if ($path eq "") then - "." -else if (fn:matches($normalized-file, $escapedDelim)) then - fn:replace($normalized-file, fn:concat("^(.*)", $escapedDelim, ".*"), "$1") -else - "." -}; +declare function file:dir-name($path as xs:string) as xs:string external; -(:~ - : This is a helper function used by dirname and base-name. This function takes a path as - : input and normalizes it according to the rules states in dirname/base-name documentation - : and normalizes it to a system specific path. - :) -declare %private function file:prepare-for-dirname-and-base-name($path as xs:string) as xs:string -{ - let $delim := file:directory-separator() - let $escapedDelim := -if ($delim eq "/") then - $delim -else - fn:concat("\", $delim) - let $normalize-path := file:path-to-native($path) - let $normalized := -if ($normalize-path eq $delim) then - $normalize-path -else - fn:replace($normalize-path, fn:concat($escapedDelim, "+$"), "") - return $normalized -}; +(: vim:set et sw=2 ts=2: :) === modified file 'modules/org/expath/ns/file.xq.src/file.cpp' --- modules/org/expath/ns/file.xq.src/file.cpp 2013-06-04 05:33:22 + +++ modules/org/expath/ns/file.xq.src/file.cpp 2013-06-12 15:40:46 + @@ -41,6 +41,25 @@ //* +BaseNameFunction::BaseNameFunction(const FileModule* aModule) + : FileFunction(aModule) +{ +} + +ItemSequen
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1189996-2013-06-12T15-31-18.989Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job bug-1189996-2013-06-12T15-31-18.989Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-06-12T15-55-56.425Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The attempt to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job pjl-misc-2013-06-12T15-55-56.425Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve I made some final changes, i.e. moved the files and improved the documentation. Concerning me, it's ready to go. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-06-12T23-59-50.355Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue job pjl-misc-2013-06-12T23-59-50.355Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-06-13T00-48-45.492Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue job pjl-misc-2013-06-13T00-48-45.492Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/168983 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1189996-2013-06-13T01-28-01.428Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Validation queue job bug-1189996-2013-06-13T01-28-01.428Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189996 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1189996 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189996/+merge/168850 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp