Re: [OpenJDK 2D-Dev] 2 small xrender fixes

2010-07-07 Thread Clemens Eisserer
Hi Phil, Strange, running your test I get width=-1 when uploading as well as rendering the glyph - and the pipeline basically just reads the native GlyphInfo structure by using Unsafe. I'll have to think about it a bit more .. Anything I could to to help to track that down? Thanks, Clemens

Re: [OpenJDK 2D-Dev] Fix for drawing round endcaps on scaled lines.

2010-07-07 Thread Jim Graham
Hi Denis, We need a lot of upgrades in this area, but they will come with some engineering cost. Note that the Ductus line widening code widens curves to curves, but many (most?) line wideners flatten everything to do widening so they only have to deal with algorithms that widen and join

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-07-07 Thread Jim Graham
For AA this is exactly what we do (round to nearest pixel centers for strokes). Note that this is done prior to any line widening code is executed. For non-AA we normalize coordinates to, I believe the (0.25, 0.25) sub-pixel location. This is so that the transitions between widening of

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-07-07 Thread Jim Graham
The first part means that if the scale is uniform in X and Y (AffineTransform has some logic to determine this property in its getType() method) then we can use X11 to do line widening by just giving it a scaled line width. Also, X11 is limited to integer line widths so we would only want to

Re: [OpenJDK 2D-Dev] Fix for uniformly scaled dashed lines.

2010-07-07 Thread Jim Graham
This looks good, but don't assert that the transform is non-singular. Transforms can frequently be singular and that isn't an exception. Actually, a singular transform simply means that the entire coordinate space has collapsed to a line or a point and so nothing need be rendered. If there