Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-08-04 Thread Jim Graham
Hi Denis, First, comments on the high level normalizer (Normalizing iterator): - If there is no normalization going on, I would use the Shape's own flattening (i.e. getPathIterator(at, flat)). The reason being that some shapes may know how to flatten themselves better, or faster, than a Flat

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-08-04 Thread Denis Lila
Hello Jim. So, I've now implemented both suggestions you had for implementing stroke control: an intermediate normalizing path iterator, and doing flattening in pisces at the lowest level. Respectively, the webrevs are: http://icedtea.classpath.org/~dlila/webrevs/fpWithStrokeControl/webrev/ http:

Re: [OpenJDK 2D-Dev] Various fixes to pisces stroke widening code

2010-08-04 Thread Denis Lila
Hello Jim. > I'd need to see a final webrev and approve it and then anyone with an > OpenJDK user id can push it. The final webrev is http://icedtea.classpath.org/~dlila/webrevs/fpBetterAAv2/webrev/ The only things that have changed since the last one you commented on are the "y == boundsMaxY -