Hi Jim,
For a complex clip it is not enough to test the two endpoints so I don't
think this fix will work for a line that spans between two portions of a
non-rectangular clip over a region that is outside the clip...
This case is handled by the native clip, so it would just be a missed
Hi Clemens,
Fix looks reasonable and good to have a fix for this!
I do think it would be safer to be better than the X11 pipeline if
possible ..
-phil.
On 4/13/2012 9:46 AM, Clemens Eisserer wrote:
Hi,
Please take a look at the patch for bug 7105461, located at
Hi Phil,
Thanks for taking a look.
Fix looks reasonable and good to have a fix for this!
I do think it would be safer to be better than the X11 pipeline if possible
I reworked the original patch a bit and put the checks at a higher
level, based on the following two assumptions:
- Clipping
I don't understand. You are checking to see if the line is inside the
clip, but your test will think that something is inside the clip when it
is not so the fast path code will be used for lines outside the clip.
If the case can handle lines outside the clip then why test at all?
Hi Jim,
I don't understand. You are checking to see if the line is inside the clip,
but your test will think that something is inside the clip when it is not so
the fast path code will be used for lines outside the clip. If the case
can handle lines outside the clip then why test at all?
