Re: [OpenJDK 2D-Dev] Suggest a modification to isPostscript exception handling

2012-08-23 Thread Sean Chou
Hi Phil, I'm really sorry about this typo, the modification looks so simple that I became careless when porting. The patch is from ibmjdk and it has been tested on Java6 since Oct, 2007 and on Java7 since Feb, 2012. To be honest, this modification isn't related to a real bug in openjdk f

Re: [OpenJDK 2D-Dev] Suggest a modification to isPostscript exception handling

2012-08-23 Thread Phil Race
Sean, Without even commenting on the merits or necessity I note that you cannot possibly have even built this patch, much less tested it. > 625 return Boolean.FLASE; -phil. On 8/23/12 1:58 AM, Sean Chou wrote: Hello, I updated the repository to 2d, the webrev is now: http://cr.openjdk.

Re: [OpenJDK 2D-Dev] [7u8] request for review: 7150594: VM chash in JCK api/java_awt/Image/ConvolveOp/ tests for 64 bit jdk8 on linux.

2012-08-23 Thread Jennifer Godinez
Approved. - Jennifer On 8/20/2012 4:30 AM, Andrew Brygin wrote: Hello, could you please review a fix for 7150594? This problem is triggered by the fix for CR 7113017. In particular, this fix replaces the malloc.h with stddef.h in mlib_types.h. This change leads to compiling mlib_sys.c wit

Re: [OpenJDK 2D-Dev] Suggest a modification to isPostscript exception handling

2012-08-23 Thread Sean Chou
Hello, I updated the repository to 2d, the webrev is now: http://cr.openjdk.java.net/~zhouyx/OJDK-429/webrev.01/ Please take a look. -- Forwarded message -- From: Sean Chou Date: Thu, Aug 23, 2012 at 2:24 PM Subject: Suggest a modification to isPostscript exception handling