Re: [OpenJDK 2D-Dev] Please review 8012381

2013-05-29 Thread Jennifer Godinez
Yes, backport to 7. The webrev shows 8 repo but file is identical in 7. Jennifer On 5/29/2013 1:54 PM, Phil Race wrote: I think you mean to back port this from 8 to 7u ? Yes, looks good. -phil. On 5/29/2013 1:44 PM, Jennifer Godinez wrote: Hi Phil and Johny, Please review backport fix for

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-29 Thread Phil Race
None of these are touched any more in the current patch, as we don't build on these targets. Right, I noted that in the first sentence of my prior email. we haven't tested on *BSD. fair enough but the difference is that there is no build line that ever copies this file, so its un-used. Fr

Re: [OpenJDK 2D-Dev] Please review 8012381

2013-05-29 Thread Phil Race
I think you mean to back port this from 8 to 7u ? Yes, looks good. -phil. On 5/29/2013 1:44 PM, Jennifer Godinez wrote: Hi Phil and Johny, Please review backport fix for 8012381 : [macosx] : Collation selection ignored when printing on MacOSX Bug: http://bugs.sun.com/view_bug.do?bug_id=8012

[OpenJDK 2D-Dev] Please review 8012381

2013-05-29 Thread Jennifer Godinez
Hi Phil and Johny, Please review backport fix for 8012381 : [macosx] : Collation selection ignored when printing on MacOSX Bug: http://bugs.sun.com/view_bug.do?bug_id=8012381 Webrev: http://cr.openjdk.java.net/~jgodinez/8012381/ Thank you. - Jennifer

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-29 Thread Andrew Hughes
- Original Message - > Jiri, > > I think this has mostly been hashed out as the fix is reduced to Linux > but here's my over-due input : > > 1) Windows *absolutely* still needs fontconfig files. > > 2) Mac OS X doesn't obey what's there but that doesn't mean its > going to work when you

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-29 Thread Phil Race
Jiri, I think this has mostly been hashed out as the fix is reduced to Linux but here's my over-due input : 1) Windows *absolutely* still needs fontconfig files. 2) Mac OS X doesn't obey what's there but that doesn't mean its going to work when you just remove them. 3) Solaris *does* want the

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

2013-05-29 Thread Phil Race
From http://www.oracle.com/technetwork/community/oca-486395.html "The OCA gives Oracle and the contributor joint copyright interests in the code ..." So you can't use AGG since you don't have the rights to contribute it under OCA terms. Also I don't think we want to swap out pisces and start

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8012381: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest

2013-05-29 Thread jennifer . godinez
Changeset: 7e2a887a069e Author:jgodinez Date: 2013-05-29 09:46 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7e2a887a069e 8012381: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest Reviewed-by: jchen, prr ! src/solaris/classes/sun/

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7183520: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest.

2013-05-29 Thread jennifer . godinez
Changeset: f4ad2fa22474 Author:jgodinez Date: 2013-05-29 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f4ad2fa22474 7183520: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest. Reviewed-by: bae, prr ! src/macosx/classes/sun/lw

Re: [OpenJDK 2D-Dev] Request for review [XS]: The XRender backend fails to render any glyphs on 64-bit Big-endian architectures

2013-05-29 Thread Andrew Hughes
- Original Message - > I haven't done it but I think it would be useful to backport the change. > > However I'm not very familiar with the process of backporting changes and > only an jdk7u author anyway so if you could do that it woud be great! > Yeah, I can propose it and CC you. I ju

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

2013-05-29 Thread Andrea Aime
On Wed, May 29, 2013 at 2:05 PM, Laurent Bourgès wrote: > Seems very interesting ... I just looked at the documentation. > > AGG code would be worth to look at but somebody should check if their > license is compatible with openjdk license terms. > > I'm not a lawyer, so take this with a grain of

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-29 Thread Andrew Hughes
- Original Message - > On 05/20/2013 04:37 PM, Jiri Vanek wrote: > > On 05/10/2013 04:08 PM, Jiri Vanek wrote: > >> On 04/08/2013 05:31 PM, Jiri Vanek wrote: > >>> On 04/08/2013 04:13 PM, Vladislav Karnaukhov wrote: > Hello Jiri, > > please see inline. > > On 4/8/20

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

2013-05-29 Thread Laurent Bourgès
Seems very interesting ... I just looked at the documentation. AGG code would be worth to look at but somebody should check if their license is compatible with openjdk license terms. Apparently AGG uses integers to convert float values (24.8 ie float are multiplied by 256 and then converted to in

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-29 Thread Jiri Vanek
On 05/20/2013 04:37 PM, Jiri Vanek wrote: On 05/10/2013 04:08 PM, Jiri Vanek wrote: On 04/08/2013 05:31 PM, Jiri Vanek wrote: On 04/08/2013 04:13 PM, Vladislav Karnaukhov wrote: Hello Jiri, please see inline. On 4/8/2013 05:29 PM, Jiri Vanek wrote: On 04/08/2013 02:39 PM, Vladislav Karnaukh

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

2013-05-29 Thread Andrea Aime
On Wed, May 29, 2013 at 11:01 AM, Laurent Bourgès wrote: > Finally I propose to focus on optimizing these 2 algorithms (methods) as > it represents 55% of cpu time: > - optimize / modify algorithms: integer instead of float ops, reduce > number of condition statements (if) to improve branch predi

Re: [OpenJDK 2D-Dev] sun.java2D.Pisces renderer Performance and Memory enhancements

2013-05-29 Thread Laurent Bourgès
Andrea, Jim and java2d members, I am going back to my work on java2d pisces improvements (scanline rendering optimization). Two comments: - hotspot takes some time to optimize the very large Renderer.endRendering() and ScalineIterator.next() methods: probably because these methods represents too