Re: [OpenJDK 2D-Dev] Request for review: JDK-6870661 Setting a custom PrintService on a PrinterJob leads to a PrinterException

2013-09-26 Thread Jennifer Godinez
Hi Patrick, Fix looks fine but can you send me a new webrev with the corrected typo and move the regression tests to a new subdirectory? Also, the manual test is reporting failure for cancel which I think should not be the case. You may look at other manual tests on how they do this. On

Re: [OpenJDK 2D-Dev] Review request for http://cr.openjdk.java.net/~ceisserer/fix10/

2013-09-26 Thread Clemens Eisserer
Hi Phil, the webrev and test need a little clean-up : adding the @test and @bug tag + GPL Please find a corrected version at http://cr.openjdk.java.net/~ceisserer/8024895/webrev.01/ along with a (hopefully) jtreg conformant testcase at

Re: [OpenJDK 2D-Dev] Request for review: JDK-6870661 Setting a custom PrintService on a PrinterJob leads to a PrinterException

2013-09-26 Thread Patrick Reinhart
Hi Jennifer, 1) What would be the correct subdirectory for those Tests? 2) The manual tests checks that the correct print dialog is shown. Unfortunately I did not found a manual test for a non applet test. Cheers Patrick On 09/26/2013 07:19 PM, Jennifer Godinez wrote: Hi Patrick, Fix looks

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-26 Thread Sean Mullan
On 09/16/2013 12:30 PM, Volker Simonis wrote: src/share/lib/security/java.security-aix - Provide default java.security-aix for AIX. The login.configuration.provider property should be set to: sun.security.provider.ConfigFile See 8016848 for more info. After you make this change,

Re: [OpenJDK 2D-Dev] Review request for http://cr.openjdk.java.net/~ceisserer/fix10/

2013-09-26 Thread Phil Race
Looks OK. I'll push once a 2nd set of eyes concurs. -phil. On 9/26/13 12:04 PM, Clemens Eisserer wrote: Hi Phil, the webrev and test need a little clean-up : adding the @test and @bug tag + GPL Please find a corrected version at http://cr.openjdk.java.net/~ceisserer/8024895/webrev.01/ along