Hello,
could you please review a fix for CR 8026702?
Bug: http://bugs.sun.com/view_bug.do?bug_id=8026702
Webrev: http://cr.openjdk.java.net/~bae/8026702/webrev.00/
Suggested fix is to declare local variables in the beginning of the
function.
Please take a look.
Thanks,
Andrew.
Looks good.
On 16.10.2013 17:00, Andrew Brygin wrote:
Hello,
could you please review a fix for CR 8026702?
Bug: http://bugs.sun.com/view_bug.do?bug_id=8026702
Webrev: http://cr.openjdk.java.net/~bae/8026702/webrev.00/
Suggested fix is to declare local variables in the beginning of the
Changeset: 070e8ec9d82c
Author:bae
Date: 2013-10-16 17:13 +0400
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/070e8ec9d82c
8026702: Fix for 8025429 breaks jdk build on windows
Reviewed-by: serb
! src/share/native/sun/java2d/cmm/lcms/LCMS.c
Hi,
As Jim pointed out, my earlier fix for bug JDK-7159455 wasn't entirely
correct as it allowed some shear-transformations to pass a check for a
fast-path although they should have been rejected. He proposed a way
of using the capabilities already provided by AffineTransform, which
is correct,
Oops!
Thanks,
Johnny Chen
On Oct 16, 2013, at 6:15 AM, andrew.bry...@oracle.com wrote:
Changeset: 070e8ec9d82c
Author:bae
Date: 2013-10-16 17:13 +0400
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/070e8ec9d82c
8026702: Fix for 8025429 breaks jdk build on windows
Changeset: 73d212a3b2eb
Author:jchen
Date: 2013-10-16 14:00 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/73d212a3b2eb
8024461: [macosx] Java crashed on mac10.9 for swing and 2d function manual test
Reviewed-by: prr, vadim, serb
!
Looks fine. With 10.9 releasing soon we'll need this in JDK 7.
You will need to send a request to 7u-dev asking for an OK to pus this.
-phil.
On 10/16/2013 2:11 PM, Johnny Chen wrote:
http://cr.openjdk.java.net/~jchen/8024461.jdk7/
Thanks,
Johnny Chen
Hi Clemens,
Now that we've narrowed it down to a quadrant rotation at best, can't we
get by with only transforming x,y and x+w,y+h? Or is the adjust method
used from other locations that might have a non-quadrant transform? (Or
do any callers depend on srcCoords and dstCoords being fully