[OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Clemens Eisserer
Please review my fix for bug JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator located at: http://cr.openjdk.java.net/~ceisserer/7082809/webrev.05/ A manual test-case is available at: http://cr.openjdk.java.net/~ceisserer/7082809/CompositeTest.java Problem

Re: [OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Andrew Brygin
Hi Clemens, a copyright header is missed in the new file XRSolidSrcPict.java. Could you please add it? Thanks, Andrew On 10/18/2013 12:21 PM, Clemens Eisserer wrote: Please review my fix for bug JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator located at:

Re: [OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Clemens Eisserer
Hi Andrew, a copyright header is missed in the new file XRSolidSrcPict.java. Could you please add it? Done. Please find the updated webrev at: http://cr.openjdk.java.net/~ceisserer/7082809/webrev.06/ Thanks, Clemens

Re: [OpenJDK 2D-Dev] Request for review: Additional fix for JDK-7159455

2013-10-18 Thread Clemens Eisserer
Another revision was required, available at: http://cr.openjdk.java.net/~ceisserer/fix12/webrev.04/ When the destination-area is quadratic, no geometry is stored inside the mask and therefore the composition-window is used for clipping and it's size has to be rounded properly. In cases where it

Re: [OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

2013-10-18 Thread Andrew Brygin
Hi Clemens, from my perspective, the fix looks fine. Thanks, Andrew On 10/18/2013 2:19 PM, Clemens Eisserer wrote: Hi Andrew, a copyright header is missed in the new file XRSolidSrcPict.java. Could you please add it? Done. Please find the updated webrev at:

[OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

2013-10-18 Thread Clemens Eisserer
Hi, Please review my fix for the issue described below at: http://cr.openjdk.java.net/~ceisserer/fix13/webrev.00/ Problem description: Phil found an issue with TransformedPaintTest, where the center point of radial gradients was stuck at (0,0) with the xrender-pipeline enabled. The center-point

Re: [OpenJDK 2D-Dev] Request for review: Additional fix for JDK-7159455

2013-10-18 Thread Phil Race
Clemens, This looks good to me. I used the Java 2D demo to test it. What were you using as a test ? I'll need to file a new bug to commit this additional fix. I'll push once Jim has OK'd this too. -phil. On 10/18/2013 4:45 AM, Clemens Eisserer wrote: Another revision was required,

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8025988: [macosx] Attribute settings don't work for JobAttributes range; ...

2013-10-18 Thread jennifer . godinez
Changeset: bcf8e9a59968 Author:jgodinez Date: 2013-10-18 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bcf8e9a59968 8025988: [macosx] Attribute settings don't work for JobAttributes range 8025990: [macosx] Attribute settings don't work for JobAttributes