Re: [OpenJDK 2D-Dev] Review request for 8024767: [TEST] need test to cover JDK-7189452

2013-10-29 Thread alexander stepanov
Hello Phil, OK, thanks, I'll remove the redundant options. Regards, Alexander On 29.10.2013 2:03, Phil Race wrote: Sorry for the delay in replying to this but I don't think you should specify these options * @run main/othervm -Dsun.java2d.xrender=True TextRenderingTest 1 - othervm is

Re: [OpenJDK 2D-Dev] Review request for 8024767: [TEST] need test to cover JDK-7189452

2013-10-29 Thread alexander stepanov
Please see the updated webrev: http://cr.openjdk.java.net/~bae/8024767/webrev.01/ Regards, Alexander On 29.10.2013 16:48, alexander stepanov wrote: Hello Phil, OK, thanks, I'll remove the redundant options. Regards, Alexander On 29.10.2013 2:03, Phil Race wrote: Sorry for the delay in

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-10-29 Thread Alexander Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.03 On 10/28/2013 2:33 PM, Artem Ananiev wrote: Hi, Alexander, a few comments: 1. SunGraphics2D.java:3076 - should isHiDPIImage() be used here? The isHiDPIImage() method is used to check that the

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-10-29 Thread Sergey Bylokhov
Hi, Alexander. The fix looks fine to me in general. But there is at least one issue. I build you fix and test it: - Consuming of cpu increased by 500 times Java2Demo on images tab. - FPS is dropped from 220(jdk8)/35(jdk7u40) to 15 in guimark2. Note that jdk6 has the same FPS(15) on my

Re: [OpenJDK 2D-Dev] Review request for 8024767: [TEST] need test to cover JDK-7189452

2013-10-29 Thread Clemens Eisserer
Hi Alexander, Please see the updated webrev: http://cr.openjdk.java.net/~bae/8024767/webrev.01/ The fix looks fine to me. Thanks for creating the test-case :) - Clemens