Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

Hello, Phil. jdk 9 now supports -target 1.6+/-source 1.6+ options only. Looks like we should use this minimum version too. If you have no objections I'll prepare the new version of the fix On 14.05.2014 21:09, Phil Race wrote: Hmm .. the thing here is that I know that Jim was very keen that

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

Perhaps we have to make that the default but add a comment that since this is bundled with JDK 9 it must use at least a 1.6 target but the intention is that it be able to be compiled with and targeted to, earlier JDKs BTW I guess dest-dist is OK but I imagine Jim really did mean dest -# java

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

The only intention was that we be able to compare against older runtimes when needed. We could ask whether we care about how we currently compare against 1.2 any more...? If we're really that curious, we can either change the target and compile with an older compiler, or find an older

[OpenJDK 2D-Dev] Review Request for JDK-6975892: Javadoc typo in javax.print.attribute.standard.DialogTypeSelection

Hi, Please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-6975892 Here is the corresponding webrev: http://cr.openjdk.java.net/~ssides/6708093/ This fix addresses the typo in the getCategory()/getName() methods and in the constructor and aligns them with the

[OpenJDK 2D-Dev] Review Request for JDK-6708093: Removal of a redundant unused native method declaration in LCMS.java

Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-6708093 The corresponding Webrev is located at: http://cr.openjdk.java.net/~ssides/6708093/ This addresses an unused native method declaration that needed to be removed. Best Regards, --

[OpenJDK 2D-Dev] Review Request for JDK-8043693: A typo in the javadoc for javax.imageio.ImageReader

Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8043693 The corresponding Webrev is located at: http://cr.openjdk.java.net/~ssides/8043693/ This addresses a typo in the description of @param width for the getDestination() method. Best

Re: [OpenJDK 2D-Dev] Review Request for JDK-8043693: A typo in the javadoc for javax.imageio.ImageReader

Approved. We ask for 2 reviewers for most code fixes but this seems like one is plenty, so you are good to go. -phil. On 8/7/14 2:47 PM, Pushan Hinduja wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8043693 The corresponding

Re: [OpenJDK 2D-Dev] Review Request for JDK-6708093: Removal of a redundant unused native method declaration in LCMS.java

Seems fine since I can't find a native definition of this method. -phil. On 8/7/14 2:51 PM, Pushan Hinduja wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-6708093 The corresponding Webrev is located at: