Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

2014-09-03 Thread Denis Fokin
Hi Sergey and 2d team, I have rewritten the fix. It works fine for text rendered on window using OpenGL. http://web-dot.ru/openjdk/8023794/webrev.00/index.html It is incomplete though. It does not work for rendering in a buffered image. Additionally, I have not tested the code on other

[OpenJDK 2D-Dev] [9] request for review: 8041465: BMPImageReader read error using ImageReadParam with set sourceRectangle

2014-09-03 Thread Andrew Brygin
Hello, could you please review a fix for CR 8041465? Bug: https://bugs.openjdk.java.net/browse/JDK-8041465 Webrev: http://cr.openjdk.java.net/~bae/8041465/9/webrev.00/ The problem happens if we perform multiple read operations from a source which is set only once. For instance, we can try

Re: [OpenJDK 2D-Dev] [9] request for review: 8041465: BMPImageReader read error using ImageReadParam with set sourceRectangle

2014-09-03 Thread Phil Race
Looks good. -phil. On 9/3/2014 5:23 AM, Andrew Brygin wrote: Hello, could you please review a fix for CR 8041465? Bug: https://bugs.openjdk.java.net/browse/JDK-8041465 Webrev: http://cr.openjdk.java.net/~bae/8041465/9/webrev.00/ The problem happens if we perform multiple read operations

Re: [OpenJDK 2D-Dev] RFR: 8056122: Upgrade JDK to use LittleCMS 2.6

2014-09-03 Thread Jennifer Godinez
Hi Phil, Is there any change to the file cmsgats.c? This sdiff link, shows blank. http://cr.openjdk.java.net/~prr/8056122/src/java.desktop/share/native/liblcms/cmscgats.c.sdiff.html Jennifer On 08/26/2014 03:26 PM, Phil Race wrote: Andrew (and at least one other brave soul), please review :-

Re: [OpenJDK 2D-Dev] RFR: 8056122: Upgrade JDK to use LittleCMS 2.6

2014-09-03 Thread Phil Race
No actual change. Perhaps there was white space .. -phil. On 9/3/2014 2:41 PM, Jennifer Godinez wrote: Hi Phil, Is there any change to the file cmsgats.c? This sdiff link, shows blank. http://cr.openjdk.java.net/~prr/8056122/src/java.desktop/share/native/liblcms/cmscgats.c.sdiff.html