Hello All,
Removed Trailing whitespace present in code.
Please find updated webrev link:
http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.02/
Thanks,
Jay
From: Jayathirth D V
Sent: Monday, October 12, 2015 2:15 PM
To: 2d-dev@openjdk.java.net; Philip Race; Sergey
Hello Alex,
Thank you for your review.
Here's the updated webrev:
http://cr.openjdk.java.net/~aivanov/8130136/jdk9/webrev.01/
Please see my comments inline.
On 12.10.2015 20:25, Alexander Potochkin wrote:
Hello Alexey
The fix looks reasonable.
However the javadoc for RemoveDC method
Gentle reminder for review.
Regards
Prasanta
On 10/9/2015 12:34 PM, prasanta sadhukhan wrote:
Hi All,
Please review a fix for jdk9
Bug: https://bugs.openjdk.java.net/browse/JDK-7161283
webrev: http://cr.openjdk.java.net/~psadhukhan/7161283/webrev.00/
The bug mentioned that FileDialog is not
Gentle reminder for review
Regards
Prasanta
On 10/6/2015 3:25 PM, prasanta sadhukhan wrote:
Hello All,
Please review a fix for jdk9
Bug: https://bugs.openjdk.java.net/browse/JDK-8023213
webrev: http://cr.openjdk.java.net/~psadhukhan/8023213/webrev.00/
drawString takes long time in mac native
Hi, Jay.
I suggest to check correct/expected result in the test instead of
previous incorrect zero.
Previously I forgot to mention, that it will be good to name the test by
some useful name instead of some bug number(see examples in
javax/imageio/plugins).
On 13.10.15 11:12, Jayathirth D V
Hi, Alexey.
Can you attach the test, which can be used to check the fix, to the
bugreport?
On 13.10.15 13:15, Alexey Ivanov wrote:
I guess you didn't add the test for a good reason,
could you please comment on that?
It's impossible to write a regression test because the failure could be
Hello Alexey
Hello Alex,
Thank you for your review.
Here's the updated webrev:
http://cr.openjdk.java.net/~aivanov/8130136/jdk9/webrev.01/
Please see my comments inline.
On 12.10.2015 20:25, Alexander Potochkin wrote:
Hello Alexey
The fix looks reasonable.
However the javadoc for