+1
On 20.10.2015 8:31, Jayathirth D V wrote:
Hi Vadim,
Thanks for throwing light on performance aspect of Boxing & Unboxing in Java.
I have made changes, so that we use Float.compare and then use equality operator to
determine whether expected & returned values are same.
Please find updated
The fix looks good to me.
On 10/19/2015 4:36 PM, Sergey Bylokhov wrote:
Hello.
Please review an updated version of the fix:
http://cr.openjdk.java.net/~serb/8041900/webrev.00
This version fix the problem of incorrect scale under retina display
after gpu is switched. The problem is that we
On 20.10.15 14:52, Semyon Sadetsky wrote:
1.
As I read about NSOpenGLPFAAllowOfflineRenderers attribute here
https://developer.apple.com/library/mac/technotes/tn2229/_index.html
To support Mac OS X 10.4 or earlier, you will need to remove this
attribute from your attribute list, as otherwise
On 10/20/2015 12:32 PM, Jennifer Godinez wrote:
Hi Phil,
I assume you've run all the manual regression tests on text?
I would not say all. But I have run the ones that relate
to text size/position/transform.
The copyright year in the regression test needs updating.
We don't need to do
Looks fine.
On 20.10.15 11:26, Jayathirth D V wrote:
Hello All,
I need one more review. Please review.
Thanks,
Jay
-Original Message-
From: Vadim Pakhnushev
Sent: Tuesday, October 20, 2015 11:44 AM
To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip Race
Subject: Re:
Approved.
- Jennifer
On 10/20/2015 01:47 PM, Phil Race wrote:
On 10/20/2015 12:32 PM, Jennifer Godinez wrote:
Hi Phil,
I assume you've run all the manual regression tests on text?
I would not say all. But I have run the ones that relate
to text size/position/transform.
The copyright year
I removed the unused deviceTransform variable.
http://cr.openjdk.java.net/~prr/8132890.1/
Is there any thing else ?
-phil.
On 10/19/2015 02:29 PM, Philip Race wrote:
On 10/19/15, 5:10 AM, Sergey Bylokhov wrote:
Hi, Phil.
Looks like in this method we have too many things named as deviceXX.
