Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

I suspect the answer is that as long as Swing/AWT use APIs that have integer coordinates, there will be cases where this hit testing might be able to know the answer in floating point coordinates, but lose the ability to answer accurately when everything is turned into integers - which often

Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

Think of this method as asking: I don't want you to waste a lot of time, but tell me if it is silly for me to even consider rendering something with these bounds. And the answer is either "Oh, yeah, it is inconceivable that those bounds would be rendered", or "Not sure, maybe, just render it

Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

So .. question to Alexandr : JComponent.paintChildren() is the only place in the JDK that consumes this API. Is this causing a particular problem with Swing hi-dpi - other than repainting in cases that maybe didn't need it ? -phil. On 6/23/2016 3:00 PM, Jim Graham wrote: Since "return

[OpenJDK 2D-Dev] [9] Review request for 8158370 Text drawn with floating pointing scale can be shifted to one pixel

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8158370 webrev: http://cr.openjdk.java.net/~alexsch/8158370/webrev.00 Char advance in user space is calculated with float precision. That leads that summed up char advances in user space can have small

Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

On 06/23/2016 05:04 AM, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8160124 webrev: http://cr.openjdk.java.net/~alexsch/8160124/webrev.00 Let's set the clip [x=5, y=5, width=5, height=5] to a graphics and call the hitClip()

Re: [OpenJDK 2D-Dev] Fix integer overflow warnings in icu layout code

* Omair Majid [2016-02-17 10:45]: > * Omair Majid [2016-01-27 15:35]: > > Hi, > > > > * Phil Race [2016-01-21 17:55]: > > > On 01/21/2016 01:50 PM, Omair Majid wrote: > > > >That said, do you think some sort of

[OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8160124 webrev: http://cr.openjdk.java.net/~alexsch/8160124/webrev.00 Let's set the clip [x=5, y=5, width=5, height=5] to a graphics and call the hitClip() with the passed rectangle [x=0, y=0, width=5,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

Hi Prasanta,   Changes are working fine. Please convert multiple single line comments to multi-line comments both in code change in test case. In test case there are some places where lines are ending with more than 80 characters. No need for review. Please change it before check-in.  

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

Hi Phil, All, Based on the offline discussion, I added the case when disk gets filled while writing to the file. Since PrintStream does not throw IOException, I added check for checkError() to do the corresponding error handling. I added it after flush() as that is where the stream will be

[OpenJDK 2D-Dev] [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8074824 (Resolve disabled warnings for libawt_xawt) As part of fixing this bug, I have - 1. Fixed warnings in source code after removing blanket warning suppressions from makefile. 2. In case the warning fix is not possible,