Re: [OpenJDK 2D-Dev] RFR: JDK-8003593: build-infra: Paths to optional platform-specific files should not be hardwired to src/closed

2016-07-04 Thread Erik Joelsson
Hello, New webrev: http://cr.openjdk.java.net/~erikj/8003593/webrev.02/ Only change is the name of the suppress variable. On 2016-07-04 03:02, David Holmes wrote: Fix typo ... On 4/07/2016 9:01 AM, David Holmes wrote: Hi Erik, Only nit with that is the "source" tend to imply source code and

[OpenJDK 2D-Dev] [9] RFR 4987884: PrinterJob carries over some values between calls to print.

2016-07-04 Thread Prasanta Sadhukhan
Hi All, Please review a fix whereby it is seen that the PageRanges attribute passed to 1st print() call is inadvertently been carried forward to 2nd print if some program tries calling in this sequence -- /PrinterJob pj = PrinterJob.getPrinterJob();// //pj.setPageable(..)// //pj.print(

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6789262: getPageFormat doesn't apply PrintRequestAttributeSet specified

2016-07-04 Thread Jayathirth D V
Hi Prasanta,   Changes are working fine.   Thanks, Jay   From: Phil Race Sent: Friday, July 01, 2016 11:55 PM To: Prasanta Sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6789262: getPageFormat doesn't apply PrintRequestAttributeSet specified   +1  ... although I am a litt

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

2016-07-04 Thread Prahalad Kumar Narayanan
Hello Everyone Good day to you. A quick follow-up on the fix for Bug ID : JDK-8152971 Title : -Xcheck:jni - WARNING in native method Thanks to Phil for his feedback. The feedback was not only detailed.. but contained important links for reference. I 've incorpo

Re: [OpenJDK 2D-Dev] [9] Review request for 8160124 SunGraphics2D.hitClip() can give wrong result for floating point scale

2016-07-04 Thread Sergey Bylokhov
On 01.07.16 2:49, Jim Graham wrote: How is it returning true? If the clip really is empty, then intersectsQuickCheck() should never return true. Or are you saying that an empty clip shape produces a non-empty composite clip region? This code will test such situation: BufferedImage bi