Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case: javax/imageio/plugins/png/ITXtTest.java is not closing a file

Good point - probably better to make it explicit then. The try-with-resources should still be cleaner for closing the streams however. Brian On Jul 7, 2016, at 1:26 PM, Phil Race wrote: > I suppose deleteOnExit might be OK but jtreg re-uses the VM > so it will not get

Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case: javax/imageio/plugins/png/ITXtTest.java is not closing a file

I suppose deleteOnExit might be OK but jtreg re-uses the VM so it will not get deleted until much later - after all N thousand tests have been run .. assuming no other test crashes the VM before then. -phil. On 07/07/2016 10:41 AM, Brian Burkhalter wrote: Why not simply invoke deleteOnExit()

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

So far as I can see we can eliminate at least some of the clutter of the calls to deletelocalreference by simply doing it as soon as we are done with the reference eg 309 familyLC = (*env)->CallObjectMethod(env, fmi->family, 310

Re: [OpenJDK 2D-Dev] [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

On 07/07/2016 10:25 AM, Semyon Sadetsky wrote: On 7/7/2016 7:48 PM, Ajit Ghaisas wrote: Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? I agree with this change. The check is not needed. Ok. so the fix overall seems fine in

Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case: javax/imageio/plugins/png/ITXtTest.java is not closing a file

you need to add the new bug to @bug .. 197 imageWriter.write(new IIOImage(src, null, m)); 198 imageOutputStream.close(); <<< 199 System.out.println("Writing done."); 200 } catch (Throwable e) { 201 if (imageOutputStream

Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case: javax/imageio/plugins/png/ITXtTest.java is not closing a file

Why not simply invoke deleteOnExit() on the file instance immediately after it is created and use try-with-resources blocks for the Image{Input,Output}Stream instances? Brian On Jul 7, 2016, at 4:38 AM, Jayathirth D V wrote: > Please review the following fix in

Re: [OpenJDK 2D-Dev] [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

On 7/7/2016 7:48 PM, Ajit Ghaisas wrote: Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? I agree with this change. The check is not needed. --Semyon Regards, Ajit -Original Message- From: Phil Race Sent: Wednesday,

Re: [OpenJDK 2D-Dev] [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? Regards, Ajit -Original Message- From: Phil Race Sent: Wednesday, July 06, 2016 2:02 AM To: Ajit Ghaisas Cc: Sergey Bylokhov; Erik Joelsson; 2d-dev;

[OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi, This change is 'L' because there are changes to a lot of files, but the changes are all similar, so it's rather easy to review. Similar to 8159690 I added @key headful to another around 600 tests. I used different patterns to grep for the headful exceptions. These are now all I could find

[OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case: javax/imageio/plugins/png/ITXtTest.java is not closing a file

Hi, Please review the following fix in JDK9 : Bug : https://bugs.openjdk.java.net/browse/JDK-7059970 Webrev : http://cr.openjdk.java.net/~jdv/7059970/webrev.00/ Root cause : Test case ITXtTest.java is not deleting the file it is creating(test.png). Also it is not closing

[OpenJDK 2D-Dev] [9] RFR: JDK-5080830: SheetCollate is not handled properly by the cross platform print dlg

Hi All, Please review a fix for an issue where it is seen that SheetCollate option is enabled for flavors that do not support SheetCollate. Bug: https://bugs.openjdk.java.net/browse/JDK-5080830 webrev: http://cr.openjdk.java.net/~psadhukhan/5080830/webrev.00/ Proposed fix to check for

Re: [OpenJDK 2D-Dev] RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

Hi, can I consider this reviewed? Remi Forax and Phil Race had a look at this. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Montag, 4. Juli 2016 08:33 > To: 'Phil Race' ; awt-...@openjdk.java.net; 2d-dev >