Re: [OpenJDK 2D-Dev] RFR: 8161407: Provide a javadoc description for java.desktop module

2016-07-18 Thread Brian Burkhalter
Looks fine to me. Brian On Jul 18, 2016, at 12:11 PM, Phil Race wrote: > Depends how fine grained we want to go. The java.base one doesn't even try > to enumerate what is in there but I did think we maybe needed to say > something .. > right now it stands out as completely empty. > > If we in

Re: [OpenJDK 2D-Dev] RFR: 8161407: Provide a javadoc description for java.desktop module

2016-07-18 Thread Phil Race
Depends how fine grained we want to go. The java.base one doesn't even try to enumerate what is in there but I did think we maybe needed to say something .. right now it stands out as completely empty. If we include all 3 I think we need to start with UI :- "User interface, graphics and imagin

Re: [OpenJDK 2D-Dev] RFR: 8054991 : sun.font.GlyphList uses broken double-checked locking

2016-07-18 Thread Philip Race
It was a reminder that there is some optimisation we can do here so I chose to leave it rather than delete it. -phil On 7/15/16, 4:04 AM, Prasanta Sadhukhan wrote: +1. But one thing, is there any need of public static GlyphList getInstance(int sz) which is commented out. I guess we can remove

Re: [OpenJDK 2D-Dev] RFR: 8161407: Provide a javadoc description for java.desktop module

2016-07-18 Thread Brian Burkhalter
Showing my own bias, how about “UI and graphics APIs” -> “graphics, imaging, and user interface APIs” ? Brian On Jul 18, 2016, at 10:50 AM, Phil Race wrote: > This fix adds the same kind of summary for desktop > > diff --git a/src/java.desktop/share/classes/module-info.java > b/src/java.desk

[OpenJDK 2D-Dev] RFR: 8161407: Provide a javadoc description for java.desktop module

2016-07-18 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8161407 The top-level "api/index.html" provides for including a summary description of a module taken from text in module-info.java eg java.base has /** * java.base defines and exports the core APIs of the Java SE platform. */ This fix adds the same

[OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

2016-07-18 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen that Banner page in linux does not get printed despite user selecting the Banner page checkbox in Printer dialog. Bug: https://bugs.openjdk.java.net/browse/JDK-6575247 webrev: http://cr.openjdk.java.net/~psadhukhan/6575247/webrev.00/