Re: [OpenJDK 2D-Dev] RFR: 8162488: JDK should be updated to use LittleCMS 2.8

On 7/25/16, 10:51 PM, Prasanta Sadhukhan wrote: Just curious, cmscgats.c#why snprintf(Buffer, 1023,...) is used for a buffer of 1024 bytes. snprintf says, The generated string has a length of at most n-1, leaving space for the additional terminating null character so if we specify 1023, th

Re: [OpenJDK 2D-Dev] RFR: 8074827: Resolve disabled warnings for libjavajpeg

Looks good. Regards Prasanta On 7/26/2016 11:10 AM, Philip Race wrote: https://bugs.openjdk.java.net/browse/JDK-8074827 http://cr.openjdk.java.net/~prr/8074827/ Passes JPRT. gcc clobbered is left since that seems to be a gcc bug fixed in a later gcc -phil.

Re: [OpenJDK 2D-Dev] RFR: 8162488: JDK should be updated to use LittleCMS 2.8

Just curious, cmscgats.c#why snprintf(Buffer, 1023,...) is used for a buffer of 1024 bytes. snprintf says, The generated string has a length of at most n-1, leaving space for the additional terminating null character so if we specify 1023, then 1022 bytes will be copied and 1023th byte will b

[OpenJDK 2D-Dev] RFR: 8074827: Resolve disabled warnings for libjavajpeg

https://bugs.openjdk.java.net/browse/JDK-8074827 http://cr.openjdk.java.net/~prr/8074827/ Passes JPRT. gcc clobbered is left since that seems to be a gcc bug fixed in a later gcc -phil.

Re: [OpenJDK 2D-Dev] RFR: JDK-8160664 JVM crashed with font manager on Solaris 12

Hi Martin, The fix looks fine. On 25.07.2016 20:30, Phil Race wrote: On 07/25/2016 07:14 AM, Martin Walsh wrote: On 07/22/16 05:59 PM, Phil Race wrote: Hi, That looks reasonable .. but before an OK I would like to see the results of running the test case in the bug report after that fix. Ru

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes disabling jar caches

+1 FWIW this being an instance method hides what it does. It seems like it should have been static but as discussed here it is too late for that :- https://bugs.openjdk.java.net/browse/JDK-4851466 -phil. On 07/25/2016 02:57 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for jdk9

Re: [OpenJDK 2D-Dev] RFR: 8162488: JDK should be updated to use LittleCMS 2.8

The alpha support does not affect JDK .. you need to set a flag to enable it - else the new code just returns - and we do not set this (new) flag. Something to investigate maybe, but no immediate or necessary impact that I see. -phil. On 07/25/2016 01:42 PM, Sergey Bylokhov wrote: On 25.07.

Re: [OpenJDK 2D-Dev] RFR: 8162488: JDK should be updated to use LittleCMS 2.8

On 25.07.16 22:41, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8162488 Webrev : http://cr.openjdk.java.net/~prr/8162488 LCMS 2.8 has been released. JDK should keep up to date. I have verified via JPRT that the updated version builds cleanly on all platforms. Also ran Java2Demo

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6278300: sun.print.Win32MediaSize deserialization error

The fix seems wrong to me .. and the problem is not easy. Windows defines standard paper sizes and we recognise those and will always serialise the "Media" as one of the built-in java pre-defined Media. But windows printer drivers very typically define additional driver-specific papers, so

[OpenJDK 2D-Dev] RFR: 8162488: JDK should be updated to use LittleCMS 2.8

Bug: https://bugs.openjdk.java.net/browse/JDK-8162488 Webrev : http://cr.openjdk.java.net/~prr/8162488 LCMS 2.8 has been released. JDK should keep up to date. I have verified via JPRT that the updated version builds cleanly on all platforms. Also ran Java2Demo and graphics/imaging/color regressi

Re: [OpenJDK 2D-Dev] RFR: 7175487: Cannot customize font configuration on Linux

Looks fine: approved. Brian On Jul 25, 2016, at 10:22 AM, Phil Race wrote: > Hi, > > Anyone able to approve this ? > I already pushed a subsequent fix that unfortunately *depends* on this fix. > So I need to get this one in ASAP > > -phil. > > On 07/21/2016 03:53 PM, Phil Race wrote: >> http

Re: [OpenJDK 2D-Dev] RFR: JDK-8160664 JVM crashed with font manager on Solaris 12

On 07/25/2016 07:14 AM, Martin Walsh wrote: On 07/22/16 05:59 PM, Phil Race wrote: Hi, That looks reasonable .. but before an OK I would like to see the results of running the test case in the bug report after that fix. Run the test case with -Dsun.java2d.debugfonts=true so we can see what the

Re: [OpenJDK 2D-Dev] RFR: 7175487: Cannot customize font configuration on Linux

Hi, Anyone able to approve this ? I already pushed a subsequent fix that unfortunately *depends* on this fix. So I need to get this one in ASAP -phil. On 07/21/2016 03:53 PM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-7175487 http://cr.openjdk.java.net/~prr/7175487/ As I note i

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes disabling jar caches

Hi Prasanta,   Changes are looking fine.   Thanks, Jay   From: Prasanta Sadhukhan Sent: Monday, July 25, 2016 3:28 PM To: Philip Race; 2d-dev Subject: [OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes disabling jar caches   Hi All, Please review a fix for jdk9 where it

Re: [OpenJDK 2D-Dev] RFR: JDK-8160664 JVM crashed with font manager on Solaris 12

On 07/22/16 05:59 PM, Phil Race wrote: Hi, That looks reasonable .. but before an OK I would like to see the results of running the test case in the bug report after that fix. Run the test case with -Dsun.java2d.debugfonts=true so we can see what the JDK is doing internally. You can add the log

[OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes disabling jar caches

Hi All, Please review a fix for jdk9 where it is seen that we are unnecessarily disabling jar caching for entire JVM execution when a IPPConnection is established, which is wrong. Bug: https://bugs.openjdk.java.net/browse/JDK-6591280 webrev: http://cr.openjdk.java.net/~psadhukhan/6591280/webre