[OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

Hi All, Please review a fix for an issue where it is seen that Print-to-File option is disabled even for SERVICE_FORMATTED DocFlavor after JDK-5049012 fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8163922 webrev: http://cr.openjdk.java.ne

[OpenJDK 2D-Dev] [9] RFR JDK-8152966: ClassCastException when adding IFD to the TIFFDirectory before the image write

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8152966 Patch: http://cr.openjdk.java.net/~bpb/8152966/webrev.00/ Move the private method getDirectoryAsIFD(TIFFDirectory) from the API class TIFFDirectory to a public method in the internal class TIFFIFD and re

[OpenJDK 2D-Dev] RFR: 8145901: Printed content is overlapping.

Bug: https://bugs.openjdk.java.net/browse/JDK-8145901 Webrev: http://cr.openjdk.java.net/~prr/8145901/ As per the evaluation in the bug this is an issue with the device scale being applied to the kerning adjustments made by the layout engine. The fix builds cleanly in JPRT and has been tested wi

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8145014: "IIOException: Couldn't seek!" when calling TIFFImageReader.getNumImages()

That is fine ... -phil. On 08/11/2016 06:59 AM, Brian Burkhalter wrote: Rethinking this slightly, I think it might be good to changes lines 218 and 236 of TIFFImageReader from imageIndex = index - 1; to imageIndex = index > 0 ? index - 1 : 0; If that looks reasonable I will

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

It appears to me that this fix has caused a regression. When I bring up this dialog (on Linux) Print To File is always greyed out. I think somewhere along the line you became we concerned about whether specific value should grey it out or not that it got lost that is no longer possible to set this

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Hi Alexandr, Should something be done to transfer the array of sizes to the new instance if the source is an MRCI? Perhaps a special case for MRCI as well that calls mrciInstance.map(mapper) instead of constructing a brand new object from scratch? ...jim On 08/11/20

[OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-4924727 Webrev : http://cr.openjdk.java.net/~jdv/4924727/webrev.00/ Issue : When we issue ImageReader.abort() in IIOReadProgressListener.imageStarted(), reading is not

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8145014: "IIOException: Couldn't seek!" when calling TIFFImageReader.getNumImages()

Rethinking this slightly, I think it might be good to changes lines 218 and 236 of TIFFImageReader from imageIndex = index - 1; to imageIndex = index > 0 ? index - 1 : 0; If that looks reasonable I will update the webrev in place and push the fix. Thanks, Brian On Aug 10, 20

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

looks good to me. Regards Prasanta On 8/11/2016 3:52 PM, Prahalad Kumar Narayanan wrote: Hello Everyone First, Thanks to Prasanta for his feedback. I 've incorporated the feedback in the code and changes are available for review. Review Link: http://cr.openjdk.java.net/~pnarayanan/81585

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

Hello Everyone First, Thanks to Prasanta for his feedback. I 've incorporated the feedback in the code and changes are available for review. Review Link: http://cr.openjdk.java.net/~pnarayanan/8158524/webrev.01/ Quick summary on changes from previous revision: . Wild card imports hav

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

Hi Phil, On 8/11/2016 3:05 AM, Phil Race wrote: There does not seem to be a link to the new webrev in here. Is it this : http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ ? > to default Paper (Letter in US, A4 otherwise) imageable area I don't think that will ever be A4. Where is that

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.03 MultiResolutionToolkitImage handing is added to the MultiResolutionCachedImage.map() method. Thanks, Alexandr. On 11/08/16 01:46, Jim Graham wrote: Ah, yes, only ToolkitImages can be "not yet loaded" i

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison

You need to use @Override annotation for paint() method. Also, you can use specific imports rather than package imports. Also, I guess it's better to throw RuntimeException than Error for failure, not sure how jtreg will react to it. Lastly, I am not sure if you can use duke.gif image which mayno