Thanks Phil for the comments.
Modified webrev:
http://cr.openjdk.java.net/~psadhukhan/6357887/webrev.02/
Regards
Prasanta
On 8/25/2016 12:05 AM, Phil Race wrote:
In fact what you should be doing here is
Attribute attr = attrs.get(Media.class);
if (attr instanceof CustomMediaTray)
The progr
FWIW I think the most important image loading use case
is that some generic resource loading code - perhaps JDK code - will get
a URL for where
the resources are and go hunting. It is never going to call this API .. so
it had better be an optimisation and not a necessity
-phil.
On 8/24/16, 5:
Alexander,
Were the existing Toolkit.getImage(String/URL) APIs not enhanced to
do this for you automatically ? I suppose I thought they were but
they can't be since you are using getImage(String) here.
IMO that would be more important than this.
And in any case I don't see why this is solved o
+1
...jim
On 8/24/16 4:41 AM, Ajit Ghaisas wrote:
Hi,
The root cause of the crash is - NaN is converted to an integer and used as
array index in mlib_ImageScanPoly.c.
The native method previously did not check the validity of the input double
argument. Now, I have added
Hi Avik,
On 8/23/16 11:43 PM, Avik Niyogi wrote:
Hi Jim,
Just a few queries I have regarding the inputs provided. I have added them
inline in red. Thank you for further inputs
in advance.
On 24-Aug-2016, at 3:02 am, Jim Graham mailto:james.gra...@oracle.com>> wrote:
I wonder why the @throws
Hi Jim,
Just a few queries I have regarding the inputs provided. I have added them
inline in red. Thank you for further inputs in advance.
> On 24-Aug-2016, at 3:02 am, Jim Graham wrote:
>
> I wonder why the @throws is not inherited...?
>
> Another way to fix this would be to implement it in t
Approved.
Brian
On Aug 24, 2016, at 12:49 PM, Phil Race wrote:
> Need a quick review to get rid of a debugging message that was
> inadvertenly included in a fix. Fix below ..
>
> https://bugs.openjdk.java.net/browse/JDK-8164752
>
>
> --- a/src/java.desktop/share/native/libfontmanager/hb-jdk-
Need a quick review to get rid of a debugging message that was
inadvertenly included in a fix. Fix below ..
https://bugs.openjdk.java.net/browse/JDK-8164752
--- a/src/java.desktop/share/native/libfontmanager/hb-jdk-font.cc
+++ b/src/java.desktop/share/native/libfontmanager/hb-jdk-font.cc
@@ -52
In fact what you should be doing here is
Attribute attr = attrs.get(Media.class);
if (attr instanceof CustomMediaTray)
The program below should show that the lookup works so long as the key
is the class understood by the API - not a sub-type.
-phil.
import javax.print.*;
import javax.print.
OK that is what I (sort of) suspected.
+1
-phil.
On 8/24/16, 10:08 AM, Prasanta Sadhukhan wrote:
Modified testcase
http://cr.openjdk.java.net/~psadhukhan/4885375/webrev.01/
On 8/24/2016 10:27 PM, Prasanta Sadhukhan wrote:
Oh, it should be return 5. I was testing the 2nd issue and forgot to
c
Modified testcase
http://cr.openjdk.java.net/~psadhukhan/4885375/webrev.01/
On 8/24/2016 10:27 PM, Prasanta Sadhukhan wrote:
Oh, it should be return 5. I was testing the 2nd issue and forgot to
change it back.
Regards
Prasanta
On 8/24/2016 10:26 PM, Philip Race wrote:
Why does the test look l
Oh, it should be return 5. I was testing the 2nd issue and forgot to
change it back.
Regards
Prasanta
On 8/24/2016 10:26 PM, Philip Race wrote:
Why does the test look like this ?
157 @Override
158 public int getNumberOfPages() {
159 return 0;
160 }
-phil.
On 8/23/1
Why does the test look like this ?
157 @Override
158 public int getNumberOfPages() {
159 return 0;
160 }
-phil.
On 8/23/16, 5:05 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix whereby it is seen that Page Ranges fields in the
"cross-platform" dialog does n
+1
Some day we should still consider an API that lets the application pass
in an owner.
-phil.
On 8/24/16, 3:39 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where it is seen that the Frame
object passed to Toolkit.getPrintJob() is not used when cross platform
pri
+1
-phil.
On 8/24/16, 4:41 AM, Ajit Ghaisas wrote:
Hi,
The root cause of the crash is - NaN is converted to an integer and used as
array index in mlib_ImageScanPoly.c.
The native method previously did not check the validity of the input double
argument. Now, I have added a check for
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8163854
webrev: http://cr.openjdk.java.net/~alexsch/8163854/webrev.00
The public API which allows to load an image with resolution variants
based on the provided media resolution naming scheme is added:
- T
+1
On 24.08.16 3:49, Brian Burkhalter wrote:
OK unless there are objections from Sergey tomorrow I will plan to push
it as-is.
Thanks,
Brian
On Aug 23, 2016, at 5:12 PM, Philip Race mailto:philip.r...@oracle.com>> wrote:
Still fine with me.
-phil.
On 8/23/16, 4:18 PM, Brian Burkhalter wro
Hi Erik, Phil,
Thank you for replying.
I understand background of JDK-8074827.
In this particular case is shift-negative-value a new warning in GCC 6?
Yes, this feature is implemented GCC 6:
https://gnu.wildebeest.org/blog/mjw/2016/02/15/looking-forward-to-gcc6-many-new-warnings/
BTW, why
Hi,
The root cause of the crash is - NaN is converted to an integer and used as
array index in mlib_ImageScanPoly.c.
The native method previously did not check the validity of the input double
argument. Now, I have added a check for finite double values.
If NaN or INF arguments are
Hi All,
Please review a fix for an issue where it is seen that the Frame object
passed to Toolkit.getPrintJob() is not used when cross platform print
dialog is created,
so the print dialog does not have an owner Frame and therefore if the
parent frame is disposed, the print dialog is not affec
Hello,
On 2016-08-23 18:12, Phil Race wrote:
On 08/23/2016 08:47 AM, Erik Joelsson wrote:
Hello,
I do agree that maintaining the list of disabled warnings will be
impossible unless we have a structured way of tracking for which
compiler versions we disable what. Ideally we should be able to e
21 matches
Mail list logo
