Hi Phil & Jim,
Thanks for your inputs.
I have verified with previous iteration of the changes and both #1 and #4 fail
from the time we have introduced the change in how we calculate "nBits" in
ColorModel.
-nBits = bits.clone();
+/*
+ * We need significant bits value
Sounds like we should at least try to get the tests updated so they only
test what the spec. says.
Although it does indicate that there is at least a chance that
application code might also fail due to similar assumptions.
Does #1 not fail with the previous iteration of this change too ?
Hello Dmitry,
The fix looks good to me, but I am not a reviewer.
I will sponsor the integration of the fix once the review is completed.
Thanks,
Dmitry
On 30/01/2017 11:53, Dmitry Batrak wrote:
Hello,
I'd like to propose a fix for JDK-8170950.
bug:
Hi Prahalad,
Changes are fine.
Thanks,
Jay
-Original Message-
From: Philip Race
Sent: Wednesday, January 25, 2017 6:48 AM
To: Prahalad Kumar Narayanan
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278:
ArrayIndexOutOfBoundsException when calling
Hi Phil,
Thanks for your review, I have updated the webrev to include your suggestions :
http://cr.openjdk.java.net/~jdv/7107905/webrev.15/
I just noticed that some JCK test are failing because of this change :
1)api/java_awt/Image/ColorModel/index.html#Constructor: Failed. test
Hello Dmitry,
Quoting from:
http://openjdk.java.net/projects/#project-author
"""
Becoming an Author
Any Contributor may request the Author role by contacting the relevant
Project Lead. References to at least two sponsored contributions to
the Project are required.
[...]
Project Leads are
Hello again,
Could you please let me know how can I request an Author status? I have 2
contributions already accepted, and I'd like to continue contributing
2d-related changes to OpenJDK. Having an Author role will make it much
simpler, as I won't need anyone's help for creating and updating