Hello Sergey
Thank you for your review response.
I had one version of the test that resembled your test code.
I uploaded the result (screenshot) of that test case with/ without fix on JBS.
The only point of concern - API documentation mentions that the methods of
FilteredImageSource are not
On 27/11/2017 22:12, Prahalad Kumar Narayanan wrote:
Yes..! As you rightly pointed, the test passes before the fix as well.
Then I suggest to additionally reuse a test which I sent previously, it
is fail almost always before the fix. The test which fails one time in
1 runs will be never
Hello Sergey
Thank you for your time in review.
Yes..! As you rightly pointed, the test passes before the fix as well.
Reason is that, the occurrence of this bug is rare.
. Submitter has observed only 15 occurrences of the exception with over
10,000 instances per month.
. Though the
Hi,
getPageFormatFromAttributes(..) was added to fix some mac specific issues :
https://bugs.openjdk.java.net/browse/JDK-8025988
https://bugs.openjdk.java.net/browse/JDK-8025990 which is why it is used
only on mac, so I think it is OK to assume it can be modified to fix a
further Mac bug. So
On 27/11/2017 14:02, Semyon Sadetsky wrote:
> The current changes get my "+1" as comformant HTML5.
This is not true. The empty tags produce warnings in HTML5 validator:
https://validator.w3.org/nu/?doc=http%3A%2F%2Fcr.openjdk.java.net%2F~ssadetsky%2F8181289%2Fjdoc%2FmodB-summary.html
The
> The current changes get my "+1" as comformant HTML5.
This is not true. The empty tags produce warnings in HTML5 validator:
https://validator.w3.org/nu/?doc=http%3A%2F%2Fcr.openjdk.java.net%2F~ssadetsky%2F8181289%2Fjdoc%2FmodB-summary.html
-phil.
On 11/22/2017 07:58 PM, Jonathan Gibbons
The current changes get my "+1" as comformant HTML5.
-phil.
On 11/22/2017 07:58 PM, Jonathan Gibbons wrote:
Semyon,
You may indeed have explained why the behavior as it is, but we cannot
and should not link this review with changes to the javadoc
stylesheets, when the specific changes in
Hi,Prahalad.
On 24/11/2017 21:40, Prahalad Kumar Narayanan wrote:
Based on discussions with Sergey, I 've now updated the fix with a test case.
The changes are available for review under:
http://cr.openjdk.java.net/~pnarayanan/8188083/webrev.01/
This version of the test is always passed before
