Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

2017-12-28 Thread Prahalad Kumar Narayanan
Hello Jay Good day to you. The code changes wrap the IllegalArgumentException in IIOException. This approach is better & aligns with how OutOfMemoryError was wrapped to fix JDK-8190332. The only point that I 'm not sure is- whether we could wrap IllegalArgumentException twice before throwing

Re: [OpenJDK 2D-Dev] jdk-hs ppc64le build error, probably related to libpng update

2017-12-28 Thread Philip Race
This all sounds fine to me. Definitely we should report this upstream to see what they say but clearly we aren't bound to wait for an answer from there since this is a build breakage for PPC. If someone upstream comes back with a better answer we can update the fix. I think this png update will

Re: [OpenJDK 2D-Dev] jdk-hs ppc64le build error, probably related to libpng update

2017-12-28 Thread Baesken, Matthias
Hi Phil, I think your idea to guard with #ifdef PNG_POWERPC_VSX_API_SUPPORTED Is fine, should I prepare a webrev using this guard ? * Wrapping in that check might be OK (for PNG_POWERPC_VSX_API_SUPPORTED) but you'll want to report this upstream. Yes it is a good idea to report this

Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

2017-12-28 Thread Jayathirth D V
Hi Prahalad, Thanks for your valuable inputs. Even though the fix resolves the issue for the particular test case we have it will not solve the buffer overflow problem as you have mentioned in highest limit case or many other cases where the computed value is very high. Also we cannot change