Thanks Phil & Sergey for your reviews.
I will push tomorrow morning (FR)...
Thanks Kevin for submitting the jfx11 bug.
FYI I am finalizing marlinFX 0.9.1 patch too (ClipShapeTest adapted)
Laurent
Le 7 mai 2018 9:20 PM, "Sergey Bylokhov" a
écrit :
Looks fine.
On
I filed https://bugs.openjdk.java.net/browse/JDK-8202743 to track
getting this fix into JavaFX.
-- Kevin
On 5/4/2018 5:30 AM, Laurent Bourgès wrote:
Sergey,
Please review this simple fix to the Dasher problem:
JBS: https://bugs.openjdk.java.net/browse/JDK-8202580
webrev:
+1
On 07/05/2018 11:57, Phil Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8176510
Webrev: http://cr.openjdk.java.net/~prr/8176510/
This test has been a bit flaky as part of what it tests is font dependent.
It relied on knowing it could find Lucida Sans and what the JDK's opentype
Looks fine.
On 07/05/2018 09:39, Philip Race wrote:
Sergey, what do you think ?
We can request a backport after the push to jdk11, if no new issues will
be found.
--
Best regards, Sergey.
Bug : https://bugs.openjdk.java.net/browse/JDK-8176510
Webrev: http://cr.openjdk.java.net/~prr/8176510/
This test has been a bit flaky as part of what it tests is font dependent.
It relied on knowing it could find Lucida Sans and what the JDK's opentype
font layout library did when it is applied
On 5/7/18, 9:27 AM, Laurent Bourgès wrote:
Phil,
Le dim. 6 mai 2018 à 01:11, Philip Race > a écrit :
Looks fine to me. Did you run the rendering related regression tests ?
I ran all tests in sun/java2d/marlin. What other tests
Phil,
Le dim. 6 mai 2018 à 01:11, Philip Race a écrit :
> Looks fine to me. Did you run the rendering related regression tests ?
>
I ran all tests in sun/java2d/marlin. What other tests should I run ?
This fix is very low risk as it fixes only the dash array usage.
>
>