Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Sergey Bylokhov
On 10/11/19 3:43 pm, Philip Race wrote: On 10/11/19, 2:52 PM, Sergey Bylokhov wrote: Hi, Phil. It looks like after the fix we will skip the call "unregisterDeferral" and the ProfileActivator which was registered by the "ProfileDeferralMgr.registerDeferral" will not be removed --> memory leak?

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Philip Race
On 10/11/19, 2:52 PM, Sergey Bylokhov wrote: Hi, Phil. It looks like after the fix we will skip the call "unregisterDeferral" and the ProfileActivator which was registered by the "ProfileDeferralMgr.registerDeferral" will not be removed --> memory leak? I discussed that below in my initi

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Philip Race
PS .. BTW do we have an option to mark this "finalize" as forRemoval=true or just delete it?(example JDK-8159009/JDK-8212198) This will be for a backport, so that would be inappropriate even if I wanted to address that now .. -phil.

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Sergey Bylokhov
Hi, Phil. It looks like after the fix we will skip the call "unregisterDeferral" and the ProfileActivator which was registered by the "ProfileDeferralMgr.registerDeferral" will not be removed --> memory leak? BTW do we have an option to mark this "finalize" as forRemoval=true or just delete it?

Re: [OpenJDK 2D-Dev] [14] RFR: JDK-8223158: Docked MacBook cannot start any Java Swing applications

2019-10-11 Thread Sergey Bylokhov
+1 On 10/11/19 6:39 am, Philip Race wrote: Ok by me. -phil On 10/10/19, 11:34 PM, Prasanta Sadhukhan wrote: Hi Phil, Sergey Then, is http://cr.openjdk.java.net/~psadhukhan/8223158/webrev.2/ good to check-in? Regards Prasanta On 11-Oct-19 2:28 AM, Sergey Bylokhov wrote: On 10/10/19 1:35 pm

[OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

2019-10-11 Thread Philip Race
Bug: ICC_Profile has un-needed, not-empty finalize method Webrev: http://cr.openjdk.java.net/~prr/8175984/ This is a native memory utilisation problem due to delay in collecting and freeing ICC_Profiles and their associated classes and data. The color management engine is native code and consume

Re: [OpenJDK 2D-Dev] [14] RFR: JDK-8223158: Docked MacBook cannot start any Java Swing applications

2019-10-11 Thread Philip Race
Ok by me. -phil On 10/10/19, 11:34 PM, Prasanta Sadhukhan wrote: Hi Phil, Sergey Then, is http://cr.openjdk.java.net/~psadhukhan/8223158/webrev.2/ good to check-in? Regards Prasanta On 11-Oct-19 2:28 AM, Sergey Bylokhov wrote: On 10/10/19 1:35 pm, Phil Race wrote: > I guess at a minimum we