Looks fine.
On 11/22/19 10:21 am, Phil Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8227324
webrev : http://cr.openjdk.java.net/~prr/8227324/
This is just a small (as these things go) upgrade from 2.10.0 to 2.10.1
Mostly miscellaneous non-critical bug fixes and some refactoring
bug: https://bugs.openjdk.java.net/browse/JDK-8227324
webrev : http://cr.openjdk.java.net/~prr/8227324/
This is just a small (as these things go) upgrade from 2.10.0 to 2.10.1
Mostly miscellaneous non-critical bug fixes and some refactoring
Builds on all platforms, no issues seen in testing.
Only thing to be concerned about is the copyright of the ttf file. If it
is not self-generated or GPL licensed or we are not sure of of its
origin(most of will be copyrighted to Adobe or such, which are not ok to
be checked in), It's better to reuse the A.ttf file already present in
the repo
Hi Dmitry,
There are some test cases which use .ttf file for test case and they keep
regression test and its corresponding .ttf file in same path.
So we can follow same approach.
Usage of hardcoded value seems reasonable here.
Thanks,
Jay
> On 22-Nov-2019, at 12:56 PM, Dmitry Batrak
>
