Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

2019-11-26 Thread Dmitry Batrak
That's what I did locally - copied the file. I was surprised by the representation of that operation in webrev. I hope this will be applied in the same way during committing. Best regards, Dmitry Batrak On Tue, Nov 26, 2019 at 11:45 PM Phil Race wrote: > This looks good to me, so long as this

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

2019-11-26 Thread Jayathirth Rao
+1. Thanks, Jay > On 27-Nov-2019, at 2:15 AM, Phil Race wrote: > > This looks good to me, so long as this is not actually moving the A.ttf file > and instead just making a new copy - despite how it appears here :- > > -- -- -- -- --- New >

[OpenJDK 2D-Dev] RFR: 8234784: Update jpeg.md to reflect code used by JDK

2019-11-26 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8234784 Webrev : http://cr.openjdk.java.net/~prr/8234784/ This is a change to the legal attribution file for JPEG. - Adds several contributors - Removes mention of components of the library that are not in JDK -phil.

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

2019-11-26 Thread Phil Race
This looks good to me, so long as this is not actually moving the A.ttf file and instead just making a new copy - despite how it appears here :- |-- -- -- -- --- New Patch

Re: [OpenJDK 2D-Dev] RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Ja

2019-11-26 Thread Baesken, Matthias
Thanks for the update on this . Do you plan to push it today or tomorrow ? Best regards, Matthias > -Original Message- > From: Prasanta Sadhukhan > Sent: Dienstag, 26. November 2019 10:26 > To: Baesken, Matthias ; Erik Joelsson > ; 'build-...@openjdk.java.net' d...@openjdk.java.net>

Re: [OpenJDK 2D-Dev] RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Ja

2019-11-26 Thread Lindenmaier, Goetz
Hi Matthias, the change looks good. Thanks for fixing this. Best regards, Goetz. > -Original Message- > From: Prasanta Sadhukhan > Sent: Dienstag, 26. November 2019 10:26 > To: Baesken, Matthias ; Erik Joelsson > ; 'build-...@openjdk.java.net' d...@openjdk.java.net> > Cc:

Re: [OpenJDK 2D-Dev] RFR: 8234769: Duplicate attribution in freetype.md

2019-11-26 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 26-Nov-19 3:09 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8234769 Webrev: http://cr.openjdk.java.net/~prr/8234769/ It looks like the update for the legal file we were given has 2 copies of text about PSaux. I just need to remove one of them.

Re: [OpenJDK 2D-Dev] RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Ja

2019-11-26 Thread Prasanta Sadhukhan
I have already raised a similar fix sometime back for JDK-8234786 Regards Prasanta On 26-Nov-19 2:49 PM, Baesken, Matthias wrote: Hello, here is a small adjustment that uses the typealias for NSTextInputSourceIdentifier . This fixes the build on macOS < 10.13 . Bug/webrev :

[OpenJDK 2D-Dev] RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java i

2019-11-26 Thread Baesken, Matthias
Hello, here is a small adjustment that uses the typealias for NSTextInputSourceIdentifier . This fixes the build on macOS < 10.13 . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8234795 http://cr.openjdk.java.net/~mbaesken/webrevs/8234795.0/ Thanks, Matthias > > If