Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

Thanks for clarification. +1 for http://cr.openjdk.java.net/~prr/8242004.1/ Regards, Jay > On 17-Apr-2020, at 4:35 AM, Philip Race wrote: > > > > On 4/12/20, 11:03 PM, Jayathirth D v wrote: >> >> Hi Phil, >> >> Thanks for the clarification. >>

Re: [OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

Thanks for the clarification. Change looks good to me. Regards, Jay > On 17-Apr-2020, at 4:04 AM, Philip Race wrote: > > > > On 4/15/20, 10:32 PM, Jayathirth D v wrote: >> Hi Phil, >> >> Thanks for the detailed evaluation in bug and here. >> Change looks good to me. >> >> Newly added file h

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

Thanks for both the reviews. Yes embed link and it is going to wrong bug. Thanks for pointing to proper link. Regards, Jay > On 17-Apr-2020, at 3:21 AM, Philip Race wrote: > > +1 > > BTW your bug link goes to the wrong bug, should go here : > https://bugs.openjdk.java.net/browse/JDK-8195841

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

On 4/12/20, 11:03 PM, Jayathirth D v wrote: Hi Phil, Thanks for the clarification. It's good that we have removed used inverseTx code. Since we don’t have inverseTx check now, do we need to explicitly return from draw() when we have non invertible transform. Yes. I think we are making

Re: [OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

On 4/15/20, 10:32 PM, Jayathirth D v wrote: Hi Phil, Thanks for the detailed evaluation in bug and here. Change looks good to me. Newly added file has copyright year 2018. Please update it before pushing. Ok. I ran smaller set of rotate tests for font and they all pass with this change.

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

+1 BTW your bug link goes to the wrong bug, should go here : https://bugs.openjdk.java.net/browse/JDK-8195841 -phil. On 4/13/20, 2:40 AM, Jayathirth D v wrote: Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8195841

Re: [OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

On 4/16/20, 6:31 AM, Sergey Bylokhov wrote: Hi, Phil. I have only the question about the new comment: 340 // Let's not adjust the metrics of any glyph that is zero advance. 341 if (slot->linearHoriAdvance == 0) { 342 return; 343 } The comments said that we do not want t

Re: [OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

Hi, Phil. I have only the question about the new comment: 340 // Let's not adjust the metrics of any glyph that is zero advance. 341 if (slot->linearHoriAdvance == 0) { 342 return; 343 } The comments said that we do not want to adjust the metrics and return, but we already a

Re: [OpenJDK 2D-Dev] RFR: 8196181 sun/java2d/GdiRendering/InsetClipping.java fails

Looks good to me. Thanks, Jay > On 13-Apr-2020, at 6:57 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk/client. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196181 > Fix: http://cr.openjdk.java.net/~serb/8196181/webrev.01 > > The test tries to take a color of th