[OpenJDK 2D-Dev] EA3 build of Project Lanai (Metal rendering pipeline for macOS) is now posted.

2020-07-09 Thread Philip Race
https://jdk.java.net/lanai/ is now hosting the EA 3 build of Lanai This is now JDK16 based since JDK 15 forked for stabilisation. Build 16-lanai+1-11 (2020/7/3) new bugs fixed # 8242950: Files which can't be selected has different color with metal than opengl in JFileChooser

Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

2020-07-09 Thread Baesken, Matthias
>There always should be a call such as FontUtilities.isLogging() test >protecting doing unnecessary work. Hi, in my patch I always call isLogging() in the new methods in

Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

2020-07-09 Thread Philip Race
I agree. There always should be a call such as FontUtilities.isLogging() test protecting doing unnecessary work. -phil. On 7/9/20, 3:24 AM, Peter Hull wrote: Probably not my place to comment, but, does it matter that it's doing unnecessary work evaluating the argument to logWarning et al, in

Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

2020-07-09 Thread Peter Hull
Probably not my place to comment, but, does it matter that it's doing unnecessary work evaluating the argument to logWarning et al, in the case where logging is not enabled? It only seems to be string concatenation and maybe would be optimised out anyway, I don't know. Peter On Thu, 9 Jul 2020 at

[OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

2020-07-09 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where "Properties" button in ServiceUI.printDialog is enabled in windows but clicking it doesn't show any dialog. According to JDK-4673406 , the properties dialog isn't supported for direct uses with

Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

2020-07-09 Thread Baesken, Matthias
Thankā€˜s for the review ! May I get a second review ? Best regards, Matthias From: Jayathirth D v Sent: Donnerstag, 9. Juli 2020 07:21 To: Baesken, Matthias Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java Looks good to