Re: [OpenJDK 2D-Dev] RFR : 8249725 : testbug: ZeroWithStringBoundsTest.java needs update to copyright header.

looks ok but I guess there's no need to update the bug id for this header updation but if you insist on it, the bugid needs to be corrected to 8249725. Regards Prasanta On 20-Jul-20 12:50 AM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8249725 The copyright header is miss

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Actually, I was a bit wrong in construing that the button should just be disabled for ServiceUI.printDialog if ServiceUIFactory is null & getUI(MAIN_ROLE...) is null. The "properties" dialog is used for another use-case which is for cross-platform dialog also ie, when we have a printer job cre

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi Prasanta, Is just checking for dialog is null fine or we also need to verify DocumentProptiesUI in our case? As done in else case when dialog is null at http://hg.openjdk.java.net/jdk/client/file/fabf11c3a8ca/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l801

[OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

PING: could you review it? JBS: https://bugs.openjdk.java.net/browse/JDK-8249215 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8249215/webrev.00/ Yasumasa On 2020/07/11 17:39, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/J