Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

On 2020/07/30 12:20, Sergey Bylokhov wrote: On 29.07.2020 19:37, Yasumasa Suenaga wrote: On 2020/07/30 11:03, Sergey Bylokhov wrote: On 28.07.2020 18:52, Yasumasa Suenaga wrote: Hi Phil, Sergey, Sorry, I missed. null is WComponentPeer::pData, not defaultFont. Could you please clarify in

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

On 29.07.2020 19:37, Yasumasa Suenaga wrote: On 2020/07/30 11:03, Sergey Bylokhov wrote: On 28.07.2020 18:52, Yasumasa Suenaga wrote: Hi Phil, Sergey, Sorry, I missed. null is WComponentPeer::pData, not defaultFont. Could you please clarify in what exact place access to the null pData in

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

On 2020/07/30 11:03, Sergey Bylokhov wrote: On 28.07.2020 18:52, Yasumasa Suenaga wrote: Hi Phil, Sergey, Sorry, I missed. null is WComponentPeer::pData, not defaultFont. Could you please clarify in what exact place access to the null pData in WComponentPeer caused a crash?

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

On 28.07.2020 18:52, Yasumasa Suenaga wrote: Hi Phil, Sergey, Sorry, I missed. null is WComponentPeer::pData, not defaultFont. Could you please clarify in what exact place access to the null pData in WComponentPeer caused a crash? I removed the change for WFontPeer from new webrev.  

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

Thanks Phil! Yasumasa On 2020/07/30 0:49, Philip Race wrote: Ok. Approved. I assume no one found a way to provoke this without changing the Windows system locale so we can't create a test. -phil. On 7/28/20, 10:40 PM, Yasumasa Suenaga wrote: On 2020/07/29 11:27, Phil Race wrote: Did you

Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

Hi Abhishek, Could you update the year in the copyright section for the modified files, please? Regards, Dmitry > On 29 Jul 2020, at 11:43, Kumar Abhishek wrote: > > Hi Alexey/Dmitry, > > Please find the updated Webrev. > http://cr.openjdk.java.net/~jdv/8200281/webrev.02/ > > I have added

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

Ok. Approved. I assume no one found a way to provoke this without changing the Windows system locale so we can't create a test. -phil. On 7/28/20, 10:40 PM, Yasumasa Suenaga wrote: On 2020/07/29 11:27, Phil Race wrote: Did you copy/paste my typo ? Looks like a . not a , in the string

Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

Hi Alexey/Dmitry, Please find the updated Webrev. http://cr.openjdk.java.net/~jdv/8200281/webrev.02/ I have added the missed annotation. Thanks, Abhishek -Original Message- From: Alexey Ivanov Sent: Saturday, July 25, 2020 2:38 AM To: Kumar Abhishek Cc: Philip Race ; 2d-dev

[OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

Hello All, Please review the following fix for JDK 16: Bug : https://bugs.openjdk.java.net/browse/JDK-8243674 Webrev : http://cr.openjdk.java.net/~jdv/8243674/webrev.00/ Issue : We have

Re: [OpenJDK 2D-Dev] RFR: 8250755 Better cleanup for jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java

Thanks for the cleanup. +1. Thanks, Jay > On 29-Jul-2020, at 2:28 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk/client. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8250755 > Fix: http://cr.openjdk.java.net/~serb/8250755/webrev.00 > > The test in question

[OpenJDK 2D-Dev] RFR: 8250755 Better cleanup for jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java

Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8250755 Fix: http://cr.openjdk.java.net/~serb/8250755/webrev.00 The test in question creates two temp files. One of them properly cleaned after

Re: [OpenJDK 2D-Dev] RFR: 8166038 BufferedImage methods getTileGridXOffset() and getTileGridYOffset() return a non 0 value for sub images

Le 25/06/2020 à 17:48, Jayathirth D v a écrit : (…snip…) And I think we should conclude the thread with Phil’s question about just returning 0 in these methods. It could be a 2 steps process. As a first step the proposed implementation is consistent with other BufferedImage method