Re: [OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

2020-07-30 Thread Sergey Bylokhov
Hi, Jay. The fix looks fine, but maybe we can to trigger added IIOException(remainingLen < 0) by the test? On 29.07.2020 02:41, Jayathirth D v wrote: Hello All, Please review the following fix for JDK 16: Bug : https://bugs.openjdk.java.net/browse/JDK-8243674 Webrev : http://cr.openjdk.java.

Re: [OpenJDK 2D-Dev] RFR: 8166038 BufferedImage methods getTileGridXOffset() and getTileGridYOffset() return a non 0 value for sub images

2020-07-30 Thread Jayathirth D v
+1. Thanks, Jay > On 28-Jul-2020, at 9:56 AM, Sergey Bylokhov > wrote: > > The new version of the fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8166038 > Fix: http://cr.openjdk.java.net/~serb/8166038/webrev.02 > > In the new version, the test was updated based on the feedback. > >

Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

2020-07-30 Thread Dmitry Markov
Looks good to me. Regards, Dmitry > On 30 Jul 2020, at 07:10, Kumar Abhishek wrote: > > Hi Dmitry, > > I have updated the year in the copyright section for the modified file. > Please find the updated Webrev:- > http://cr.openjdk.java.net/~jdv/8200281/webrev.03/ > > > Thanks, > Abhishek > --