Re: [OpenJDK 2D-Dev] RFR[8250855]: 'Address reliance on default constructors in the Java 2D APIs'

2020-08-31 Thread Philip Race
Right we have started to be consistent using "Constructor for subclasses to call": Also I prefer constructs over creates, even for the concrete classes, eg this : + +/** + * Creates an {@code ImageFilter}. + */ +public ImageFilter() {} + should be "Constructs an {@code

Re: [OpenJDK 2D-Dev] [EXTERNAL] Re: RFR: 8234393 [macos] printing ignores printer tray

2020-08-31 Thread Vipin Mv1
Hi Philip, Thanks for the review comments. The testcase test/jdk/java/awt/print/PrinterJob/TestMediaTraySelection.java seems to be intended to test only the MediaTray functionality. Also, it doesn't seems to have anything that is Linux specific. Rather than having a new testcase wouldn't it