Re: [OpenJDK 2D-Dev] RFR: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode

2021-02-11 Thread Prasanta Sadhukhan
On Thu, 11 Feb 2021 18:42:30 GMT, Phil Race wrote: > The various CF*Copy* functions called here need a matching CFRelease src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m line 578: > 576: (*env)->CallBooleanMethod(env, arrayListOfString, addMID, > jFontName); > 577:

Re: [OpenJDK 2D-Dev] RFR: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode

2021-02-11 Thread Prasanta Sadhukhan
On Thu, 11 Feb 2021 18:42:30 GMT, Phil Race wrote: > The various CF*Copy* functions called here need a matching CFRelease src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m line 575: > 573: #endif > 574: jstring jFontName = (jstring)NSStringToJavaString(env, fontname); > 575:

Re: [OpenJDK 2D-Dev] RFR: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode

2021-02-11 Thread Prasanta Sadhukhan
On Fri, 12 Feb 2021 04:42:34 GMT, Prasanta Sadhukhan wrote: >> The various CF*Copy* functions called here need a matching CFRelease > > src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m line 575: > >> 573: #endif >> 574: jstring jFontName = (jstring)NSStringToJavaString(env,

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v7]

2021-02-11 Thread Philip Race
I have worked out how to pass this option to at least the jtreg tests for the lanai headful mach5 job, so once this is fixed we can check it out in jtreg and get some level of confidence  that we are checking all the important cases. Note that we know some tests will fail just because it spits

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v7]

2021-02-11 Thread Phil Race
On Thu, 11 Feb 2021 21:04:16 GMT, Gerard Ziemski wrote: >> I guess you will only see this if `Metal API Validation Enabled` > > Which actually begs a question of whether we tested with `Metal API > Validation Enabled` ? I submitted https://bugs.openjdk.java.net/browse/JDK-8261620 for this bug.

[OpenJDK 2D-Dev] Integrated: 8261282: Lazy initialization of built-in ICC_Profile/ColorSpace classes is too lazy

2021-02-11 Thread Sergey Bylokhov
On Sun, 7 Feb 2021 05:36:52 GMT, Sergey Bylokhov wrote: > Short fix description: > > The fix changes the initialization of the built-in color profiles/spaces from > the lazy initialization per requested profile via static synchronization to > the lazy initialization of all profiles/spaces on

Re: [OpenJDK 2D-Dev] RFR: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode

2021-02-11 Thread Sergey Bylokhov
On Thu, 11 Feb 2021 18:42:30 GMT, Phil Race wrote: > The various CF*Copy* functions called here need a matching CFRelease Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2532

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v7]

2021-02-11 Thread Gerard Ziemski
On Thu, 11 Feb 2021 20:58:36 GMT, Gerard Ziemski wrote: >> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m line 112: >> >>> 110: sourceSize:MTLSizeMake(self.buffer.width, >>> self.buffer.height, 1) >>> 111: toTexture:mtlDrawable.texture

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v7]

2021-02-11 Thread Gerard Ziemski
On Thu, 11 Feb 2021 20:55:35 GMT, Gerard Ziemski wrote: >> Ajit Ghaisas has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Lanai PR#181 - 8261143 - aghaisas >> - Lanai PR#180 - 8261546 - jdv > >

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v7]

2021-02-11 Thread Gerard Ziemski
On Thu, 11 Feb 2021 11:51:57 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal

Re: [OpenJDK 2D-Dev] RFR: 8260695: The java.awt.color.ICC_Profile#getData/getData(int) are not thread safe [v3]

2021-02-11 Thread Sergey Bylokhov
> Both methods are implemented in a similar way. > 1. Requests the size of the profile/tag data > 2. Creates an array of the correct size > 3. Requests the data and copy it to the array > > If the data will be changed concurrently between steps 2. and 3. then we will > get a mismatch between

Re: [OpenJDK 2D-Dev] RFR: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode

2021-02-11 Thread Phil Race
On Thu, 11 Feb 2021 19:45:07 GMT, Sergey Bylokhov wrote: > Is it a long-standing bug or caused by the JNF removal? long-standing. - PR: https://git.openjdk.java.net/jdk/pull/2532

Re: [OpenJDK 2D-Dev] RFR: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode

2021-02-11 Thread Sergey Bylokhov
On Thu, 11 Feb 2021 18:42:30 GMT, Phil Race wrote: > The various CF*Copy* functions called here need a matching CFRelease Is it a long-standing bug or caused by the JNF removal? - PR: https://git.openjdk.java.net/jdk/pull/2532

[OpenJDK 2D-Dev] RFR: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode

2021-02-11 Thread Phil Race
The various CF*Copy* functions called here need a matching CFRelease - Commit messages: - 8261533: ava_sun_font_CFont_getCascadeList leaks memory according to Xcode Instruments leak profile Changes: https://git.openjdk.java.net/jdk/pull/2532/files Webrev:

Re: [OpenJDK 2D-Dev] RFR: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method [v5]

2021-02-11 Thread Prasanta Sadhukhan
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument > would actually clear the existing clipping area, which is incorrect. > This statement is applicable only to G2D.setClip() and not for the clip() > method. G2D.clip() would throw a NullPointerException when it

Re: [OpenJDK 2D-Dev] RFR: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method [v4]

2021-02-11 Thread Alexander Zvegintsev
On Thu, 11 Feb 2021 04:14:54 GMT, Prasanta Sadhukhan wrote: >> The API doc for Graphics2D.clip(shape s) claims that passing a null argument >> would actually clear the existing clipping area, which is incorrect. >> This statement is applicable only to G2D.setClip() and not for the clip() >>

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v7]

2021-02-11 Thread Ajit Ghaisas
> **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > The entire work on this was done under [OpenJDK Project