Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-04-30 Thread Sergey Bylokhov
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 I assume the build using bundled lib is fine on all our platforms. - Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3826

Re: [OpenJDK 2D-Dev] RFR: 8266171: -Warray-bounds happens in imageioJPEG.c [v2]

2021-04-30 Thread Yasumasa Suenaga
On Fri, 30 Apr 2021 18:17:39 GMT, Phil Race wrote: >> I also think GCC does not do any static analysis of the code calling. And >> also the code uses `struct` like a C++ class, so I guess GCC reports >> incorrect warnings at this point. >> Many -Warray-bounds related issues are reported in

Re: [OpenJDK 2D-Dev] RFR: 8266171: -Warray-bounds happens in imageioJPEG.c [v2]

2021-04-30 Thread Yasumasa Suenaga
> We can see following compiler warnings in imageioJPEG.c on GCC 11. Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision: Disable -Warray-bounds in makefile - Changes: - all:

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-04-30 Thread Alexey Ivanov
On Wed, 10 Mar 2021 20:53:43 GMT, Alexey Ivanov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp >> >> Select one icon at a time. >>

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-04-30 Thread Alexey Ivanov
On Wed, 10 Mar 2021 20:40:40 GMT, Alexey Ivanov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp >> >> Select one icon at a time. >>

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-04-30 Thread Alexey Ivanov
On Thu, 29 Apr 2021 17:04:17 GMT, Alexander Zuev wrote: >> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line >> 1114: >> >>> 1112: bothIcons.put(getLargeIcon? >>> SMALL_ICON_SIZE : LARGE_ICON_SIZE, newIcon2); >>> 1113:

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-04-30 Thread Alexey Ivanov
On Fri, 30 Apr 2021 12:27:19 GMT, Alexander Zuev wrote: >> Fix updated after first round of review. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp >

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-04-30 Thread Alexey Ivanov
On Thu, 29 Apr 2021 18:47:27 GMT, Alexander Zuev wrote: >> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line >> 1044: >> >>> 1042: new BufferedImage(iconSize, iconSize, >>> BufferedImage.TYPE_INT_ARGB); >>> 1043: img.setRGB(0,

[OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-04-30 Thread Phil Race
Upgrade to harfbuzz 2.8 - Commit messages: - 8261169: Upgrade HarfBuzz to the latest 2.8.0 Changes: https://git.openjdk.java.net/jdk/pull/3826/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3826=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261169 Stats: 13120

[OpenJDK 2D-Dev] Integrated: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all

2021-04-30 Thread Daniel D . Daugherty
On Fri, 30 Apr 2021 19:32:43 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on > linux-x64. This pull request has now been integrated. Changeset: 50fa1623 Author:Daniel D. Daugherty URL:

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all [v2]

2021-04-30 Thread Phil Race
On Fri, 30 Apr 2021 19:52:17 GMT, Daniel D. Daugherty wrote: >> A trivial fix to ProblemList >> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on >> linux-x64. > > Daniel D. Daugherty has updated the pull request incrementally with one > additional commit since the

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all [v2]

2021-04-30 Thread Daniel D . Daugherty
On Fri, 30 Apr 2021 19:46:46 GMT, Mikael Vidstedt wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use 'generic-all' for >> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java entry. > >

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all [v2]

2021-04-30 Thread Mikael Vidstedt
On Fri, 30 Apr 2021 19:49:17 GMT, Daniel D. Daugherty wrote: >> A trivial fix to ProblemList >> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on >> linux-x64. > > Daniel D. Daugherty has updated the pull request incrementally with one > additional commit since the

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all

2021-04-30 Thread Daniel D . Daugherty
On Fri, 30 Apr 2021 19:32:43 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on > linux-x64. Will do. - PR: https://git.openjdk.java.net/jdk/pull/3824

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all [v2]

2021-04-30 Thread Phil Race
On Fri, 30 Apr 2021 19:49:17 GMT, Daniel D. Daugherty wrote: >> A trivial fix to ProblemList >> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on >> linux-x64. > > Daniel D. Daugherty has updated the pull request incrementally with one > additional commit since the

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all [v2]

2021-04-30 Thread Daniel D . Daugherty
> A trivial fix to ProblemList > java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on > linux-x64. Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: Use 'generic-all' for

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all

2021-04-30 Thread Phil Race
On Fri, 30 Apr 2021 19:32:43 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on > linux-x64. Please make it generic - PR: https://git.openjdk.java.net/jdk/pull/3824

Re: [OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on linux-x64

2021-04-30 Thread Mikael Vidstedt
On Fri, 30 Apr 2021 19:32:43 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on > linux-x64. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3824

[OpenJDK 2D-Dev] RFR: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on linux-x64

2021-04-30 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on linux-x64. - Commit messages: - 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on linux-x64 Changes:

Re: [OpenJDK 2D-Dev] RFR: 8266171: -Warray-bounds happens in imageioJPEG.c

2021-04-30 Thread Phil Race
On Fri, 30 Apr 2021 00:18:15 GMT, Yasumasa Suenaga wrote: >> src/java.desktop/share/native/libjavajpeg/imageioJPEG.c line 673: >> >>> 671: if (info->is_decompressor) { >>> 672: j_decompress_ptr dinfo = (j_decompress_ptr) info; >>> 673: #ifdef __GNUC__ >> >> I know how these

[OpenJDK 2D-Dev] Integrated: 8266040: Lanai: Incorrect calculations of clipping boundaries

2021-04-30 Thread Alexey Ushakov
On Wed, 28 Apr 2021 10:55:48 GMT, Alexey Ushakov wrote: > Adjust initial clipping values to correctly calculate shape clip boundary This pull request has now been integrated. Changeset: 87de5b75 Author:Alexey Ushakov Committer: Jayathirth D V URL:

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-04-30 Thread Alexander Zuev
> Fix updated after first round of review. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp Select one icon at a time. Co-authored-by: Alexey Ivanov

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v3]

2021-04-30 Thread Alexander Zuev
On Wed, 10 Mar 2021 20:44:19 GMT, Alexey Ivanov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp >> >> Select one icon at a time. >>

Re: [OpenJDK 2D-Dev] RFR: 8266040: Lanai: Incorrect calculations of clipping boundaries

2021-04-30 Thread Jayathirth D V
On Wed, 28 Apr 2021 10:55:48 GMT, Alexey Ushakov wrote: > Adjust initial clipping values to correctly calculate shape clip boundary LGTM. jtreg and JCK all test run is fine. J2DDemo and SwingSet2 looks good. Ran RenderPerfTest and saw improvement in ClipFlatOval/ClipFlatOvalAA from ~10FPS to

[OpenJDK 2D-Dev] Integrated: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-30 Thread Alexander Scherbatiy
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method with scaled