Re: [OpenJDK 2D-Dev] Heads up : JDK 17 b19 through b22 will use Metal instead of OpenGL for Java 2D rendering on macOS.

2021-05-06 Thread Philip Race
> I’ve only tried a couple of apps and only this test program has shown the problem. Did you try to attach something ? the lists strip attachments. Sent it directly to me and I'll see if I can add it to a bug report. -phil. On 5/6/21 2:50 PM, Alan Snyder wrote: On May 6, 2021, at 1:45 PM,

Re: [OpenJDK 2D-Dev] Heads up : JDK 17 b19 through b22 will use Metal instead of OpenGL for Java 2D rendering on macOS.

2021-05-06 Thread Alan Snyder
> On May 6, 2021, at 1:45 PM, Philip Race wrote: > > Alan, > > I am not sure this is a known issue. We'll need a lot more details. I figured you would. :-) > What is your h+w and OS update ? iMac 27 inch 2020 Radeon Pro 5500 XT 8 GB 11.3.1 > Is this all windows in an app or just the

Re: [OpenJDK 2D-Dev] RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled

2021-05-06 Thread Phil Race
On Thu, 22 Apr 2021 09:21:20 GMT, Toshio Nakamura wrote: > Hi, > > Could you review the fix? > When non-English characters were printed from JTable on MacOS, > CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, > CTextPipe seems not support glyph with slot number of

Re: [OpenJDK 2D-Dev] Heads up : JDK 17 b19 through b22 will use Metal instead of OpenGL for Java 2D rendering on macOS.

2021-05-06 Thread Philip Race
Alan, I am not sure this is a known issue. We'll need a lot more details. What is your h+w and OS update ? Is this all windows in an app or just the first one ? Does it matter what the window content is ? Any app or some specific app ? -phil. On 4/29/21 7:18 PM, Alan Snyder wrote: I am

Re: [OpenJDK 2D-Dev] Heads up : JDK 17 b19 through b22 will use Metal instead of OpenGL for Java 2D rendering on macOS.

2021-05-06 Thread Alan Snyder
I am seeing some unusual behavior (in b20) that I do not see using OpenGL (or using JDK 16). Sometimes when I open a new window, the window appears blank (except for the title bar) for about two seconds before the content appears. This behavior is not consistent. Opening another instance of

Re: [OpenJDK 2D-Dev] RFR: 8263583: Emoji rendering on macOS [v2]

2021-05-06 Thread Phil Race
On Fri, 19 Mar 2021 13:48:12 GMT, Dmitry Batrak wrote: >> This is the implementation used by JetBrains Runtime for the last 4 years, >> after some cleanup, and with one problem, >> found while preparing the pull request, fixed. >> Even though typical scenarios for a UI application should be

Re: [OpenJDK 2D-Dev] RFR: JDK-8263467: Incorrect double-checked locking in sun.java2d.CRenderer [v2]

2021-05-06 Thread Phil Race
On Fri, 12 Mar 2021 07:22:26 GMT, Aleksey Shipilev wrote: >> SonarCloud reports multiple incorrect double-checked locking cases in >> `sun.java2d.CRenderer`. For example: >> >> >> Arc2D arcToShape; >> >> ... >> if (arcToShape == null) { >> synchronized (this)

Re: [OpenJDK 2D-Dev] RFR: 8265062: Remove duplication constant MaxTextureSize

2021-05-06 Thread Phil Race
On Thu, 15 Apr 2021 14:42:55 GMT, Denis Konoplev wrote: > I've removed MaxTextureSize and replaced its usages with > MTL_GPU_FAMILY_MAC_TXT_SIZE Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3519

Re: [OpenJDK 2D-Dev] RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

2021-05-06 Thread Phil Race
On Wed, 5 May 2021 07:37:23 GMT, Jayathirth D V wrote: >> We have many if else conditions to select OpenGL/Metal pipeline objects. >> Apart from initialization phase we should not fetch these objects everytime >> checking whether we are using OpenGL/Metal pipeline. > > Jayathirth D V has

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Thomas Stuefe
On Thu, 6 May 2021 16:38:52 GMT, Phil Race wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> switch off warning in build instead of fixing it > > The policy is to do what you ended up doing. We (almost) never

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Phil Race
On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe wrote: >> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS >> issue. >> >> I fixed the issue in the harfbuzz sources, but I am not sure of the policy >> here. Do we modify the harfbuzz sources or leave them untouched?

[OpenJDK 2D-Dev] Integrated: 8252758: Lanai: Optimize index calculation while copying glyphs

2021-05-06 Thread Jayathirth D V
On Wed, 5 May 2021 13:50:47 GMT, Jayathirth D V wrote: > Loop optimization while copying glyph content. > J2DDemo, SwingSet2 and Font2DTest are green. This pull request has now been integrated. Changeset: 2438498a Author:Jayathirth D V URL:

[OpenJDK 2D-Dev] Integrated: JDK-8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify

2021-05-06 Thread Matthias Baesken
On Wed, 10 Mar 2021 12:31:31 GMT, Matthias Baesken wrote: > In java/awt/font/TextJustifier.java justify-method there is a potential code > path where divison by zero might happen , see also the Sonar finding >

Re: [OpenJDK 2D-Dev] RFR: 8252758: Lanai: Optimize index calculation while copying glyphs

2021-05-06 Thread Pankaj Bansal
On Wed, 5 May 2021 13:50:47 GMT, Jayathirth D V wrote: > Loop optimization while copying glyph content. > J2DDemo, SwingSet2 and Font2DTest are green. Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3883

Re: [OpenJDK 2D-Dev] RFR: JDK-8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify [v2]

2021-05-06 Thread Prasanta Sadhukhan
On Wed, 5 May 2021 14:11:16 GMT, Matthias Baesken wrote: >> In java/awt/font/TextJustifier.java justify-method there is a potential code >> path where divison by zero might happen , see also the Sonar finding >>

Re: [OpenJDK 2D-Dev] RFR: 8252758: Lanai: Optimize index calculation while copying glyphs

2021-05-06 Thread Ajit Ghaisas
On Wed, 5 May 2021 13:50:47 GMT, Jayathirth D V wrote: > Loop optimization while copying glyph content. > J2DDemo, SwingSet2 and Font2DTest are green. Marked as reviewed by aghaisas (Committer). - PR: https://git.openjdk.java.net/jdk/pull/3883

[OpenJDK 2D-Dev] Integrated: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-06 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Thomas Stuefe
On Thu, 6 May 2021 07:53:52 GMT, Richard Reingruber wrote: > Looks good to me, thanks! > Personally I'm building with gcc 9. I've test your fix successfully with gcc > 7.5. > > Cheers, Richard. Thanks Richard! I tested the build on Debian with gcc 7 and gcc 9, it worked. Since I now have

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Richard Reingruber
On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe wrote: >> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS >> issue. >> >> I fixed the issue in the harfbuzz sources, but I am not sure of the policy >> here. Do we modify the harfbuzz sources or leave them untouched?

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Thomas Stuefe
On Thu, 6 May 2021 06:16:36 GMT, Aleksey Shipilev wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> switch off warning in build instead of fixing it > > FWIW, current jdk master builds fine with gcc 9.3.0. It fails

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-06 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Thomas Stuefe
> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice is > welcome. > > The patch fixes linux x64 fastdebug

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-06 Thread Aleksey Shipilev
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice