Re: [OpenJDK 2D-Dev] RFR: 8267184: JEP 411: Add -Djava.security.manager=allow to tests calling System.setSecurityManager

2021-05-17 Thread Alan Bateman
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote: > Please review the test changes for [JEP > 411](https://openjdk.java.net/jeps/411). > > With JEP 411 and the default value of `-Djava.security.manager` becoming > `disallow`, tests calling `System.setSecurityManager()` need >

Re: [OpenJDK 2D-Dev] RFR: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics [v3]

2021-05-17 Thread Ajit Ghaisas
On Mon, 17 May 2021 07:54:30 GMT, Alexey Ushakov wrote: >> Added one more bit for subIndex > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The

Re: [OpenJDK 2D-Dev] RFR: 8267184: JEP 411: Add -Djava.security.manager=allow to tests calling System.setSecurityManager

2021-05-17 Thread David Holmes
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote: > Please review the test changes for [JEP > 411](https://openjdk.java.net/jeps/411). > > With JEP 411 and the default value of `-Djava.security.manager` becoming > `disallow`, tests calling `System.setSecurityManager()` need >

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v9]

2021-05-17 Thread Alexander Zuev
> Fix updated after first round of review. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Fixed documentation based on CSR review feedback - Changes: - all: https://git.openjdk.java.net/jdk/pull/2875/files - new:

Re: [OpenJDK 2D-Dev] RFR: 8263583: Emoji rendering on macOS [v3]

2021-05-17 Thread Sergey Bylokhov
On Fri, 7 May 2021 08:02:36 GMT, Dmitry Batrak wrote: >> This is the implementation used by JetBrains Runtime for the last 4 years, >> after some cleanup, and with one problem, >> found while preparing the pull request, fixed. >> Even though typical scenarios for a UI application should be

Re: [OpenJDK 2D-Dev] RFR: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics [v3]

2021-05-17 Thread Sergey Bylokhov
On Mon, 17 May 2021 07:54:30 GMT, Alexey Ushakov wrote: >> Added one more bit for subIndex > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The

Re: [OpenJDK 2D-Dev] RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-17 Thread Erik Joelsson
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: [OpenJDK 2D-Dev] RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-17 Thread Weijun Wang
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

[OpenJDK 2D-Dev] RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-17 Thread Weijun Wang
Please review this implementation of [JEP 411](https://openjdk.java.net/jeps/411). The code change is divided into 3 commits. Please review them one by one. 1. https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 The essential change for this JEP, including the

[OpenJDK 2D-Dev] RFR: 8267184: JEP 411: Add -Djava.security.manager=allow to tests calling System.setSecurityManager

2021-05-17 Thread Weijun Wang
Please review the test changes for [JEP 411](https://openjdk.java.net/jeps/411). With JEP 411 and the default value of `-Djava.security.manager` becoming `disallow`, tests calling `System.setSecurityManager()` need `-Djava.security.manager=allow` when launched. This PR covers such changes for

Re: [OpenJDK 2D-Dev] RFR: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"

2021-05-17 Thread Anton Litvinov
On Fri, 14 May 2021 18:37:46 GMT, Anton Litvinov wrote: > Hello, > > Could you please review the following fix for the bug specific to macOS. The > bug consists in the fact that if the method > "java.awt.print.Printable.print​(Graphics, PageFormat, int)" throws >

[OpenJDK 2D-Dev] Integrated: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS

2021-05-17 Thread Ajit Ghaisas
On Mon, 17 May 2021 10:18:54 GMT, Ajit Ghaisas wrote: > This PR reverts to OpenGL as the default Java2D rendering pipeline for macOS. > > Note : from JBS description : > In JDK 17 build 19 under bug id > [JDK-8265304](https://bugs.openjdk.java.net/browse/JDK-8265304) we switched > to Metal as

Re: [OpenJDK 2D-Dev] RFR: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS

2021-05-17 Thread Kevin Rushforth
On Mon, 17 May 2021 10:18:54 GMT, Ajit Ghaisas wrote: > This PR reverts to OpenGL as the default Java2D rendering pipeline for macOS. > > Note : from JBS description : > In JDK 17 build 19 under bug id > [JDK-8265304](https://bugs.openjdk.java.net/browse/JDK-8265304) we switched > to Metal as