Re: [OpenJDK 2D-Dev] RFR: 8266159: macOS ARM + Metal pipeline shows artifacts on Swing Menu with Java L [v2]

2021-06-07 Thread Jayathirth D V
On Mon, 7 Jun 2021 12:03:35 GMT, Ajit Ghaisas wrote: >> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2 >> demo is run with uiScale=1.0. >> >> **Issue :** >> SwingSet2 Demo - As reported in JBS description >> J2DDemo - As reported in a comment on JBS >> >> **Root

Re: [OpenJDK 2D-Dev] RFR: 8266159: macOS ARM + Metal pipeline shows artifacts on Swing Menu with Java L [v2]

2021-06-07 Thread Phil Race
On Mon, 7 Jun 2021 12:03:35 GMT, Ajit Ghaisas wrote: >> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2 >> demo is run with uiScale=1.0. >> >> **Issue :** >> SwingSet2 Demo - As reported in JBS description >> J2DDemo - As reported in a comment on JBS >> >> **Root

Re: [OpenJDK 2D-Dev] RFR: 8264666: Reuse Math.multiplyExact/addExact in the LCMSImageLayout class

2021-06-07 Thread Sergey Bylokhov
On Fri, 2 Apr 2021 23:02:50 GMT, Sergey Bylokhov wrote: > - The hand-crafted methods for addition and multiplication are replaced by > the "Math" versions. > - Cleanup: the usage of do/while(false) is removed not now - PR: https://git.openjdk.java.net/jdk/pull/

Re: [OpenJDK 2D-Dev] RFR: 8266159: macOS ARM + Metal pipeline shows artifacts on Swing Menu with Java L [v2]

2021-06-07 Thread Sergey Bylokhov
On Mon, 7 Jun 2021 12:03:35 GMT, Ajit Ghaisas wrote: >> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2 >> demo is run with uiScale=1.0. >> >> **Issue :** >> SwingSet2 Demo - As reported in JBS description >> J2DDemo - As reported in a comment on JBS >> >> **Root

[OpenJDK 2D-Dev] Integrated: 8261549: Adjust memory size in MTLTexurePool.m

2021-06-07 Thread Alexey Ushakov
On Tue, 1 Jun 2021 09:20:07 GMT, Alexey Ushakov wrote: > Used MTLDevice recommendedMaxWorkingSetSize property for optimal size of the > texture pool This pull request has now been integrated. Changeset: 7e55569e Author:Alexey Ushakov URL:

Re: [OpenJDK 2D-Dev] RFR: 8261549: Adjust memory size in MTLTexurePool.m [v2]

2021-06-07 Thread Phil Race
On Mon, 7 Jun 2021 10:39:26 GMT, Alexey Ushakov wrote: >> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexurePool.m >> line 328: >> >>> 326: if (_maxPoolMemory < MAX_POOL_MEMORY) { >>> 327: _maxPoolMemory = MAX_POOL_MEMORY; >>> 328: } >> >> The Apple 5K retina

Re: [OpenJDK 2D-Dev] RFR: 8261549: Adjust memory size in MTLTexurePool.m [v2]

2021-06-07 Thread Phil Race
On Mon, 7 Jun 2021 15:12:44 GMT, Alexey Ushakov wrote: >> Used MTLDevice recommendedMaxWorkingSetSize property for optimal size of the >> texture pool > > Alexey Ushakov has updated the pull request incrementally with one additional > commit since the last revision: > > 8261549: Adjust

Re: [OpenJDK 2D-Dev] RFR: 8261549: Adjust memory size in MTLTexurePool.m [v2]

2021-06-07 Thread Alexey Ushakov
> Used MTLDevice recommendedMaxWorkingSetSize property for optimal size of the > texture pool Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision: 8261549: Adjust memory size in MTLTexurePool.m Increased default pool size

Re: [OpenJDK 2D-Dev] RFR: 8266159: macOS ARM + Metal pipeline shows artifacts on Swing Menu with Java L [v2]

2021-06-07 Thread Ajit Ghaisas
> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2 > demo is run with uiScale=1.0. > > **Issue :** > SwingSet2 Demo - As reported in JBS description > J2DDemo - As reported in a comment on JBS > > **Root Cause :** > DrawPixel path is used only with uiScale=1.0. >

Re: [OpenJDK 2D-Dev] RFR: 8266159: macOS ARM + Metal pipeline shows artifacts on Swing Menu with Java L

2021-06-07 Thread Ajit Ghaisas
On Sat, 5 Jun 2021 07:46:30 GMT, Sergey Bylokhov wrote: > Is it possible to cover this fix with some automated test? Looks non of > existed tests found this issue. Draw Pixel operation is unpredictable on macOS M1 with metal pipeline if [[point_size]] is not defined. Due to this

Re: [OpenJDK 2D-Dev] RFR: 8261549: Adjust memory size in MTLTexurePool.m

2021-06-07 Thread Alexey Ushakov
On Sat, 5 Jun 2021 23:46:12 GMT, Phil Race wrote: >> Used MTLDevice recommendedMaxWorkingSetSize property for optimal size of the >> texture pool > > src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexurePool.m line > 328: > >> 326: if (_maxPoolMemory < MAX_POOL_MEMORY) { >>