Re: [OpenJDK 2D-Dev] RFR: 8269806: Emoji rendering on Linux

2021-08-04 Thread Nikita Gubarkov
Can somebody take a look at this, please? https://github.com/openjdk/jdk/pull/4798

Re: [OpenJDK 2D-Dev] RFR: 8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9 [v2]

2021-08-04 Thread Sergey Bylokhov
On Wed, 4 Aug 2021 20:10:50 GMT, Phil Race wrote: >> These fields >> - have not been used by the implementation since JDK8, >> - are not supposed to be used by applications, >> - have been deprecated for removal since JDK 9 >> - are non-standard, JDK not Java, classes >> - very few clients are

Re: [OpenJDK 2D-Dev] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v2]

2021-08-04 Thread Sergey Bylokhov
On Tue, 3 Aug 2021 20:04:14 GMT, Alexey Ushakov wrote: >> How to reproduce that artifact? > > 1. Run SwingSet2 > 2. Click on all tabs starting from the second one > 3. On the tab with swing tree control try to expand some tree nodes -> you'll > see black rectangles while performing the clicks

Re: [OpenJDK 2D-Dev] RFR: 8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9 [v2]

2021-08-04 Thread Phil Race
On Wed, 21 Jul 2021 07:19:02 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8268824: Remove unused jdk.accessibility APIs deprecated for removal in >> JDK 9 > >

Re: [OpenJDK 2D-Dev] RFR: 8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9 [v2]

2021-08-04 Thread Phil Race
> These fields > - have not been used by the implementation since JDK8, > - are not supposed to be used by applications, > - have been deprecated for removal since JDK 9 > - are non-standard, JDK not Java, classes > - very few clients are expected to be using these classes : just those >

Re: [OpenJDK 2D-Dev] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v2]

2021-08-04 Thread Alexey Ushakov
> Keep MTLLayer opacity in sync with window content view > Keep layer translucent for translucent windows Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL

[OpenJDK 2D-Dev] Integrated: 8271456: Avoid looking up standard charsets in "java.desktop" module

2021-08-04 Thread Sergey Bylokhov
On Sun, 1 Aug 2021 07:07:21 GMT, Sergey Bylokhov wrote: > This is a request to clean up a desktop module as was done in JDK-8233884 for > "java.base" module. > > In many places standard charsets are looked up via their names, for example: > absolutePath.getBytes("UTF-8"); > > This could be

Re: [OpenJDK 2D-Dev] RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module [v4]

2021-08-04 Thread Alexey Ivanov
On Tue, 3 Aug 2021 23:42:55 GMT, Sergey Bylokhov wrote: >> This is a request to clean up a desktop module as was done in JDK-8233884 >> for "java.base" module. >> >> In many places standard charsets are looked up via their names, for example: >> absolutePath.getBytes("UTF-8"); >> >> This

[OpenJDK 2D-Dev] Integrated: 8270893: IndexOutOfBoundsException while reading large TIFF file

2021-08-04 Thread Jayathirth D V
On Tue, 20 Jul 2021 06:25:22 GMT, Jayathirth D V wrote: > We are incorrectly passing source offset to ImageInputStream.readFully() > which is getting used on destination buffer. streamPos maintained in each > implementation of stream maintain's appropriate source offset while reading > the

Re: [OpenJDK 2D-Dev] RFR: 8270893: IndexOutOfBoundsException while reading large TIFF file [v2]

2021-08-04 Thread Jayathirth D V
On Tue, 3 Aug 2021 19:03:59 GMT, Sergey Bylokhov wrote: > Thank you! look fine. > BTW Looks like stream.readFully(unit, 0, sz) can be simplified to the > stream.readFully(unit)? Thanks for the review. Yes we can simplify readFully(), looks like we have other instances of similar usage of

Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v4]

2021-08-04 Thread Maxim Kartashev
On Mon, 19 Jul 2021 09:38:27 GMT, Maxim Kartashev wrote: >> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and >> `ExceptionClear()` immediately after the Java calls made from the callback >> function `ReadTTFontFileFunc()` in `freetypeScaler.c`. >> >> The exception(s) need