[OpenJDK 2D-Dev] [11] RFR for JDK-8201433: Fix potential crash in BufImg_SetupICM

2018-04-12 Thread Alexey Ivanov
Hi, Please review the fix for jdk11: bug: https://bugs.openjdk.java.net/browse/JDK-8201433 webrev: http://cr.openjdk.java.net/~aivanov/8201433/jdk11/webrev.00/ When the JVM is run with limited amount of memory, initCubemap function called from BufImg_SetupICM can return NULL. It can lead to

[OpenJDK 2D-Dev] [11] RFR for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData

2018-04-11 Thread Alexey Ivanov
Hi, Please review the fix for jdk11: bug: https://bugs.openjdk.java.net/browse/JDK-8201240 webrev: http://cr.openjdk.java.net/~aivanov/8201240/jdk11/webrev.00/ BufImgSurfaceData.ICMColorData uses finalize() to dispose of native resources. 2D components usually use Java 2D Disposer. It can

Re: [OpenJDK 2D-Dev] RFR: JDK-8160664 JVM crashed with font manager on Solaris 12

2016-07-27 Thread Alexey Ivanov
Hi Martin, Phil, I have pushed the fix. Changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/25e32d8c26c8 Regards, Alexey On 26.07.2016 8:35, Alexey Ivanov wrote: Hi Martin, The fix looks fine. On 25.07.2016 20:30, Phil Race wrote: On 07/25/2016 07:14 AM, Martin Walsh wrote: On 07

Re: [OpenJDK 2D-Dev] RFR: JDK-8160664 JVM crashed with font manager on Solaris 12

2016-07-25 Thread Alexey Ivanov
Hi Martin, The fix looks fine. On 25.07.2016 20:30, Phil Race wrote: On 07/25/2016 07:14 AM, Martin Walsh wrote: On 07/22/16 05:59 PM, Phil Race wrote: Hi, That looks reasonable .. but before an OK I would like to see the results of running the test case in the bug report after that fix.

Re: [OpenJDK 2D-Dev] RFR: 8054991 : sun.font.GlyphList uses broken double-checked locking

2016-07-14 Thread Alexey Ivanov
Looks good. Regards, Alexey On 14.07.2016 1:29, Phil Race wrote: This almost got lost. I have updated the fix See http://cr.openjdk.java.net/~prr/8054991/ -phil. On 05/26/2016 05:23 AM, Alexey Ivanov wrote: Hi Phil, Since reusableGL is written only once, I'm for marking the field final

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

2016-06-03 Thread Alexey Ivanov
Hi Phil, Sergey, I pushed the fix and submitted a new bug https://bugs.openjdk.java.net/browse/JDK-8158637 Regards, Alexey On 01.06.2016 20:25, Alexey Ivanov wrote: Hi Phil, Sergey, Thank you for reviewing! I suggest pushing the current version of the fix: http://cr.openjdk.java.net/~bae

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

2016-06-01 Thread Alexey Ivanov
to investigate the behavior. We will update getClosestStyle() if necessary. Thanks, Alexey On 01.06.2016 13:21, Alexey Ivanov wrote: Hi Phil, On 01.06.2016 0:07, Phil Race wrote: getClosestStyle() is something of a last resort. Historically I think it was called only when you had only a font

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

2016-06-01 Thread Alexey Ivanov
{ return plain; } } Good catch! The discussion is in progress… Regards, Alexey -phil. Thank you in advance, Alexey On 22.07.2015 19:33, Alexey Ivanov wrote: Hi Phil, On 16.07.2015 21:38, Phil Race wrote: On 07/16/2015 06:08 AM, Andrew Brygin wrote: Hi Phil

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

2016-06-01 Thread Alexey Ivanov
; } } -phil. Thank you in advance, Alexey On 22.07.2015 19:33, Alexey Ivanov wrote: Hi Phil, On 16.07.2015 21:38, Phil Race wrote: On 07/16/2015 06:08 AM, Andrew Brygin wrote: Hi Phil, another option to avoid the problem is to be a bit more specific regarding the required font when

Re: [OpenJDK 2D-Dev] RFR: 8054991 : sun.font.GlyphList uses broken double-checked locking

2016-05-26 Thread Alexey Ivanov
Hi Phil, Since reusableGL is written only once, I'm for marking the field final. The proposed patch is attached to JBS bug under the name 'pp'. Marking inUse field as volatile seems enough to fix the issue. However the suggested patch makes code cleaner. Regards, Alexey On 26.05.2016

Re: [OpenJDK 2D-Dev] [PATCH] JDK-8146035: Windows - With LCD antialiasing, some glyphs are not rendered correctly

2016-04-26 Thread Alexey Ivanov
The patch is also available at http://cr.openjdk.java.net/~aivanov/dmitry.batrak/8146035/jdk9/webrev.00/ The fix has been integrated into 9/client https://bugs.openjdk.java.net/browse/JDK-8146035 and to 8u-dev https://bugs.openjdk.java.net/browse/JDK-8154232 Regards, Alexey On 12.04.2016

Re: [OpenJDK 2D-Dev] [PATCH] JDK-8146035: Windows - With LCD antialiasing, some glyphs are not rendered correctly

2016-04-14 Thread Alexey Ivanov
Hi Phil, Thank you very much for your reviewing the code and approving the fix. I have uploaded the webrev to OpenJDK: http://cr.openjdk.java.net/~aivanov/dmitry.batrak/8146035/jdk9/webrev.00/ The patch is the same. On 12.04.2016 20:22, Phil Race wrote: Alexey didn't say this but he already

Re: [OpenJDK 2D-Dev] [PATCH] JDK-8146035: Windows - With LCD antialiasing, some glyphs are not rendered correctly

2016-04-11 Thread Alexey Ivanov
Hello Dmitry, Thank you very much for your patch. The fix looks good to me. I will sponsor integrating the fix into the code base as soon as code review is complete. Thanks, Alexey On 07.04.2016 15:26, Dmitry Batrak wrote: Hello, I'd like to propose a fix for JDK-8146035. I am not a

Re: [OpenJDK 2D-Dev] [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-04-04 Thread Alexey Ivanov
. Regards, Sean. On 12/02/2016 08:19, Alexey Ivanov wrote: I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you please review the fix for JDK-8147807 and approve push to 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8147807 Webrev: http

Re: [OpenJDK 2D-Dev] [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-12 Thread Alexey Ivanov
I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you please review the fix for JDK-8147807 and approve push to 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8147807 Webrev: http://cr.openjdk.java.net/~aivanov/8147807/jdk8/webrev.00/ The issue

[OpenJDK 2D-Dev] [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-11 Thread Alexey Ivanov
Hello, Could you please review the fix for JDK-8147807 and approve push to 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8147807 Webrev: http://cr.openjdk.java.net/~aivanov/8147807/jdk8/webrev.00/ The issue is not relevant to jdk 9. The fix just removes kcms service leaving lcms as

Re: [OpenJDK 2D-Dev] [9] Review request for 8130136: Swing window sometimes fails to repaint partially when it becomes exposed

2015-10-16 Thread Alexey Ivanov
to the bug as well as a demo app which demonstrates this problem exists. Regards, Alexey On 13.10.2015 18:38, Sergey Bylokhov wrote: Hi, Alexey. Can you attach the test, which can be used to check the fix, to the bugreport? On 13.10.15 13:15, Alexey Ivanov wrote: I guess you didn't add the test

Re: [OpenJDK 2D-Dev] [9] Review request for 8130136: Swing window sometimes fails to repaint partially when it becomes exposed

2015-10-14 Thread Alexey Ivanov
on that? It's impossible to write a regression test because the failure could be caught only from the native AWT code, no user code could detect it. Additionally, the time it takes to reproduce the issue is indefinite. Regards, Alexey Thanks alexp On 10/12/2015 12:11, Alexey Ivanov wrote: Hello

Re: [OpenJDK 2D-Dev] [9] Review request for 8130136: Swing window sometimes fails to repaint partially when it becomes exposed

2015-10-13 Thread Alexey Ivanov
is indefinite. Regards, Alexey Thanks alexp On 10/12/2015 12:11, Alexey Ivanov wrote: Hello, Please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8130136 webrev: http://cr.openjdk.java.net/~aivanov/8130136/jdk9/webrev.00/ Problem description: Sometimes a window

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

2015-07-22 Thread Alexey Ivanov
Hi Phil, On 16.07.2015 21:38, Phil Race wrote: On 07/16/2015 06:08 AM, Andrew Brygin wrote: Hi Phil, another option to avoid the problem is to be a bit more specific regarding the required font when we obtaining lcd glyph from GDI. If we specify a particular name of the font which we

Re: [OpenJDK 2D-Dev] [9] Review Request: 8046007: Java app receives javax.print.PrintException: Printer is not accepting job

2014-08-13 Thread Alexey Ivanov
Hello Phil, Andrew, Thank you very much for your review. Regards, Alexey. On 11.08.2014 13:48, Andrew Brygin wrote: Hello Alexey, the fix looks fine to me. Thanks, Andrew On 8/11/2014 1:42 PM, Alexey Ivanov wrote: Hello, Could anybody please review the fix as the second reviewer

Re: [OpenJDK 2D-Dev] [9] Review Request: 8046007: Java app receives javax.print.PrintException: Printer is not accepting job

2014-08-11 Thread Alexey Ivanov
some of these states being deleted ought instead to bubble up into a PrinterState of STOPPED and appropriate PrinterStateReasons but that's something that can be handled separately. -phil. On 7/22/14 7:52 AM, Alexey Ivanov wrote: Hi Phil, Jennifer, Could you please review this fix? Thank you

Re: [OpenJDK 2D-Dev] [9] Review Request: 8046007: Java app receives javax.print.PrintException: Printer is not accepting job

2014-07-22 Thread Alexey Ivanov
Hi Phil, Jennifer, Could you please review this fix? Thank you in advance, Alexey. On 16.07.2014 17:09, Alexey Ivanov wrote: Hello, Please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8046007 webrev: http://cr.openjdk.java.net/~aivanov/8046007/jdk9/webrev.00

[OpenJDK 2D-Dev] [9] Review Request: 8046007: Java app receives javax.print.PrintException: Printer is not accepting job

2014-07-16 Thread Alexey Ivanov
Hello, Please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8046007 webrev: http://cr.openjdk.java.net/~aivanov/8046007/jdk9/webrev.00/ Problem description: If printer is an error state for some reason, Java application cannot post a new print job to printer

<    1   2   3