Re: [OpenJDK 2D-Dev] RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Chris Hegarty
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: [OpenJDK 2D-Dev] RFR: 8250859: Address reliance on default constructors in the Accessibility APIs

2020-09-16 Thread Chris Hegarty
On Tue, 15 Sep 2020 19:40:28 GMT, Phil Race wrote: >> This issue relates to JDK-8250639 '☂ Address reliance on default >> constructors in the java.desktop module'. The >> following classes have had an explicit no-arg constructor added, with a >> protected access modifier and accompanying API

Re: [OpenJDK 2D-Dev] RFR: 8147544: Remove sun.misc.ManagedLocalsThread from java.desktop

2016-04-03 Thread Chris Hegarty
On 1 Apr 2016, at 23:19, Phil Race wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8147544 > Fix: http://cr.openjdk.java.net/~prr/8147544/ Your changes look ok to me. Thanks for doing this Phil. -Chris. > ManagedLocalThreads is now superseded by a standard >

[OpenJDK 2D-Dev] Fwd: RFR [9] 8140606: Update library code to use internal Unsafe

2015-11-06 Thread Chris Hegarty
Forwarding to additional area specific mailing lists, as there are changes in the webrev that affect their area. -Chris. Begin forwarded message: > From: Chris Hegarty <chris.hega...@oracle.com> > Subject: RFR [9] 8140606: Update library code to use internal Unsafe > Date: 28 Oct

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-12-02 Thread Chris Hegarty
On 26 Nov 2013, at 18:08, Iris Clark wrote: So overall it looks good to me and should be pushed to the staging forest once you hear from others that commented previously. I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan, please correct me if I'm wrong. I'm

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Chris Hegarty
Volker, I skimmed over the networking part of the changes, and nothing jumps out at me. I'd like to spend a little more time doing a more detailed review, but I will not have time to do this until after JavaOne. -Chris. On 09/16/2013 08:30 PM, Volker Simonis wrote: Resending this to more

Re: [OpenJDK 2D-Dev] 8017109: Cleanup overrides warning in src/solaris/classes/sun/print/AttributeClass.java

2013-06-20 Thread Chris Hegarty
On 06/19/2013 10:38 PM, Kurchi Hazra wrote: Hi, The class src/solaris/classes/sun/print/AttributeClass.java overrides Object.equals() but not Object.hashCode() because of which we get a warning everytime we build jdk8/tl. Here is a suggestion to remove the warning:

Re: [OpenJDK 2D-Dev] Warning Fixes from LJC Hack Session

2012-02-10 Thread Chris Hegarty
message and push the fix. Thanks! s'marks [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143230 [2] http://mail.openjdk.java.net/pipermail/jdk8-dev/2012-February/000715.html [3] http://openjdk.java.net/guide/producingChangeset.html On 2/4/12 12:12 AM, Chris Hegarty wrote: Thanks

Re: [OpenJDK 2D-Dev] Warning Fixes from LJC Hack Session

2012-02-04 Thread Chris Hegarty
I think you should just drop the changes to this file. -Chris. Michael Barker mike...@gmail.com wrote: Oh, good catch Alan, I missed this. This part of the change should be reversed ( at least in the context of warnings cleanup ). Should I switch it to a wild card (protected transient

Re: [OpenJDK 2D-Dev] AWT Dev Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2012-01-26 Thread Chris Hegarty
Ananiev wrote: Hi, Chris, the fix looks fine. Thanks, Artem On 11/9/2011 4:28 PM, Chris Hegarty wrote: Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside in the same directory as libawt. xawt/libmawt.so - libawt_xawt.so headless/libmawt.so

[OpenJDK 2D-Dev] RFR 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers

2011-12-01 Thread Chris Hegarty
This is a follow up to an issue that came up during discussion of another fix. Essentially, JDK classes should use j.u.ServiceLoader rather than sun.misc.Service. http://cr.openjdk.java.net/~chegar/7116946/webrev.00/webrev/ And a few warning cleanups, given the date that's in it ;-) Since