Looks good.
Jennifer
On 7/22/2016 1:02 PM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8162429
http://cr.openjdk.java.net/~prr/8162429/
Clean up some now obsolete font code.
-phil.
Looks good.
Jennifer
On 05/05/2016 06:33 AM, Sergey Bylokhov wrote:
Looks fine.
On 29.04.16 22:35, Phil Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8155682
Webrev: http://cr.openjdk.java.net/~prr/8155682/
None of these flags have been referenced since (I think) the current
Hi Prasanta,
It looks to me that we missed to check (flags & PD_NOSELECTION) in
setNativeAttributes that's why we are setting SunPageSelection attribute
when we shouldn't. I think that is where we should put the fix.
Jennifer
On 04/15/2016 03:34 AM, prasanta sadhukhan wrote:
Hi Phil,
On
Looks good.
Jennifer
On 04/04/2016 03:33 PM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8134986
When converted from a HashSet to a HashMap contains() should have
changed to containsKey(). It does not lead to duplicate fonts because
it is caught later on but it might lead to
Vote: Yes
- Jennifer
On 3/17/2016 3:49 PM, Philip Race wrote:
I hereby nominate Alexander Scherbatiy to membership in the 2D group.
Alexander Scherbatiy is a current member of the Swing group
and has contributed almost 200 changesets to OpenJDK :-
Hi Prasanta,
Looks good.
Jennifer
On 03/08/2016 02:26 AM, prasanta sadhukhan wrote:
Hi Phil,
It's my mistake. There's no need to copy as we are not passing the
supportedDocFlavors outside the class. I was influenced by the lines
before this where copyFlavors was copied from
Looks good.
Jennifer
On 12/16/2015 01:12 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8145584/
https://bugs.openjdk.java.net/browse/JDK-8145584
The bug is that the code that tries to measure where the bounds
of the rendering is not applying the same rounding of the rendering
position
Looks good.
Jennifer
On 12/07/2015 10:03 AM, Phil Race wrote:
Fixed : http://cr.openjdk.java.net/~prr/8137106.1/
-phil.
On 12/07/2015 09:21 AM, Philip Race wrote:
Yeah .. that should have been true. I'll upload a fixed patch.
-phil.
On 12/7/15, 8:14 AM, Sergey Bylokhov wrote:
Hi, Phil.
It
Vote: Yes
- Jennifer
On 12/07/2015 12:29 PM, Phil Race wrote:
I hereby nominate Sergey Bylokhov to membership in the 2D group.
Sergey has been a de facto member of the group for a long time and
has contributed numerous substantial fixes and provided many code reviews.
Votes are due by 21st
Looks good. Approved.
Jennifer
- Original Message -
From: prasanta.sadhuk...@oracle.com
To: philip.r...@oracle.com
Cc: 2d-dev@openjdk.java.net, rajeev.cham...@oracle.com
Sent: Friday, November 13, 2015 3:36:15 AM GMT -08:00 US/Canada Pacific
Subject: Re: [OpenJDK 2D-Dev] [9] RFR
Looks good. Approved.
Jennifer
On 11/13/2015 2:26 PM, Philip Race wrote:
I have managed to create a regression test that I think I can trust on
OS X
Updated webrev :- http://cr.openjdk.java.net/~prr/7162125.1
-phil.
On 11/12/15, 9:48 PM, Philip Race wrote:
Bug:
Approved.
- Jennifer
On 10/20/2015 01:47 PM, Phil Race wrote:
On 10/20/2015 12:32 PM, Jennifer Godinez wrote:
Hi Phil,
I assume you've run all the manual regression tests on text?
I would not say all. But I have run the ones that relate
to text size/position/transform.
The copyright year
Looks good.
Jennifer
On 09/23/2015 02:18 PM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8137059
http://cr.openjdk.java.net/~prr/8137059/
This is a follow-up to https://bugs.openjdk.java.net/browse/JDK-8136783
This new change cleans up the demos and one additional JDK source
Looks good. Don't we need regression test though?
- Jennifer
On 09/23/2015 07:43 AM, Phil Race wrote:
Any takers ?
-phil.
On 9/18/15 1:00 PM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8133309
http://cr.openjdk.java.net/~prr/8133309/
Add Segoe UI Symbol (available on Vista
Hi Phil,
Looks good.
Jennifer
On 8/12/15 2:01 PM, Phil Race wrote:
Hi all,
Still looking for any reviewers for this 7 day old review ...
-phil.
On 8/5/15 12:15 PM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8132850
http://cr.openjdk.java.net/~prr/8132850/
The bug is an
Looks good.
- Jennifer
On 04/17/2015 12:27 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8076979/
https://bugs.openjdk.java.net/browse/JDK-8076979
-phil.
Looks good.
Jennifer
On 04/29/2015 10:43 AM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8079067
http://cr.openjdk.java.net/~prr/8079067/
Just deleting unused code.
-phil.
Looks good.
Jennifer
On 11/06/2014 10:50 AM, Phil Race wrote:
Any takers ?
-phil.
On 10/30/2014 11:14 AM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8062163
http://cr.openjdk.java.net/~prr/8062163/
Fixes a test that currently fails because of a JDK9 b33 change
in the
Hi Phil,
The change looks fine.
Jennifer
On 10/27/2014 02:49 PM, Phil Race wrote:
I can add othervm but each VM invocation slows down the
overall testing time and I'd like to think this only will be run on
versions that do not have the bug.
I added the custom time out code so that I was not
Hi Phil,
Looks good.
Jennifer
On 10/17/2014 2:19 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8061392/
https://bugs.openjdk.java.net/browse/JDK-8061392
A check for null was missing
This was partly to blame for a JavaFX printing bug.
-phil.
Looks good.
- Jennifer
On 10/16/2014 01:32 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8061267/
https://bugs.openjdk.java.net/browse/JDK-8061267
An apparently old issue that the specified page ranges don't get
displayed
because we forgot to set the flag bit ...
-phil.
Looks good.
- Jennifer
On 10/9/2014 12:09 PM, Phil Race wrote:
Apparently jigsaw finds it inconvenient that the service provider
class names
are different for Windows vs the rest of the platforms, so this fix
basically
just renames both classes to PrintServiceLookupProvider.
I did jprt build
Looks good.
- Jennifer
On 10/3/2014 12:22 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8059219/
https://bugs.openjdk.java.net/browse/JDK-8059219
Straightforward fix for a very old bug ..
-phil.
Hi Phil,
Is there any change to the file cmsgats.c? This sdiff link, shows blank.
http://cr.openjdk.java.net/~prr/8056122/src/java.desktop/share/native/liblcms/cmscgats.c.sdiff.html
Jennifer
On 08/26/2014 03:26 PM, Phil Race wrote:
Andrew (and at least one other brave soul), please review :-
Looks good. Approved.
- Jennifer
On 06/27/2014 01:40 PM, Phil Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8048583
Fix : http://cr.openjdk.java.net/~prr/8048583/
As described in the bug the basic problem is that we associate
a printer defined media with an inappropriate
Looks good.
- Jennifer
On 6/3/14 11:42 AM, Joe Darcy wrote:
On 06/03/2014 11:34 AM, Phil Race wrote:
Both of these came in via an IBM contributed fix :-
http://mail.openjdk.java.net/pipermail/2d-dev/2011-October/002206.html
He [it appears] wanted to be very sure the throw was executed but it
Looks good.
Jennifer
On 05/23/2014 02:50 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8035301/
https://bugs.openjdk.java.net/browse/JDK-8035301
Builds cleanly. Client tests run.
-phil.
Checked. They are identical.
- Jennifer
On 5/22/2014 2:45 PM, Phil Race wrote:
On 5/22/14 2:39 PM, Phil Race wrote:
JDK 9 changeset :
http://hg.openjdk.java.net/jdk9/client/jdk/rev/006f772bbc7e
Sorry copy paste problems that should have been
Approved.
Jennifer
On 4/4/2014 11:29 AM, Phil Race wrote:
Jennifer Andrew,
Please check the identical JDK8u20 backport of the fix for the
(theoretical) memory
leak in awt_Font.c that you approved for JDK9
Bug link: https://bugs.openjdk.java.net/browse/JDK-8031095
Synopsis: [Parfait] warning
Looks good.
Jennifer
On 4/4/2014 12:01 PM, Phil Race wrote:
Jennifer Sergey,
Please check the identical JDK8u20 backport of the fix for the
JNI corrrectness fix in WPrinterJob.cpp that you previously approved
for JDK 9
Bug link: https://bugs.openjdk.java.net/browse/JDK- 8035569
Synopsis:
Looks good.
- Jennifer
On 04/03/2014 09:13 AM, Sergey Bylokhov wrote:
Hi, Phil.
looks good.
On 4/2/14 1:34 AM, Phil Race wrote:
Sergey Jennifer,
Please review 3 mostly windows related JNI correctness backports to
jdk8u20 that you previously approved for JDK 9
Bug link:
Looks good.
- Jennifer
On 03/29/2014 03:00 PM, Phil Race wrote:
Sergey Jennifer,
Please review/check 6 MacOSX backports of JNI correctness fixes of
changes
you previously reviewed approved for JDK 9.
They are all one per-file and exact copies of what was pushed into
jdk9/client.
I have
Approved.
- Jennifer
On 03/28/2014 11:30 AM, Phil Race wrote:
Jennifer,
Can you pls review this fix for
https://bugs.openjdk.java.net/browse/JDK-8037506
[javadoc] broken link in java.awt.geom.Line2D.java
The suggested fix came from the pubs team.
-phil.
hg diff
Looks good.
- Jennifer
On 02/11/2014 12:36 PM, Phil Race wrote:
The closed source library dcpr (ductus) needs to reference a JNU function
So an update is needed to a build file :
This needs a quick review as I (ahem) pushed the closed part but
not this ... not of relevance to open source users
Looks good. Approved.
- Jennifer
On 2/9/2014 9:12 PM, Joe Darcy wrote:
Hello,
Please review the proposed fix for
JDK-8034050: Fix serial lint warnings in javax.print
http://cr.openjdk.java.net/~darcy/8034050.0/
I checked that the added serialVerionUID values match the serialver
Approved.
Jennifer
On 02/06/2014 02:31 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8032693/
This is a fix for https://bugs.openjdk.java.net/browse/JDK-8032693
It was introduced by the JDK 8 b115 fix for
https://bugs.openjdk.java.net/browse/JDK-8022536
The root of the issue is that
Changeset: 723bcc68738b
Author:jgodinez
Date: 2013-11-26 10:24 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/723bcc68738b
8028584: sun.net.www.protocol.file.FileURLConnection cannot be cast to
java.net.HttpURLConnection
Reviewed-by: bae, prr
!
http://cr.openjdk.java.net/~jgodinez/8028584/webrev.00/
ClassCastException occurs when device uri is a file. Added a check for
file and additional safeguard against cast exception.
Jennifer
Changeset: 2a3e21fe9d0d
Author:jgodinez
Date: 2013-10-21 13:18 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2a3e21fe9d0d
8026951: Fix for 8025988 breaks jdk build on windows
Reviewed-by: prr, jchen
! src/share/classes/sun/print/RasterPrinterJob.java
Changeset: bcf8e9a59968
Author:jgodinez
Date: 2013-10-18 15:30 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bcf8e9a59968
8025988: [macosx] Attribute settings don't work for JobAttributes range
8025990: [macosx] Attribute settings don't work for JobAttributes
Changeset: 0df5cda89a50
Author:jchen
Date: 2013-10-15 14:16 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0df5cda89a50
8025429: [parfait] warnings from b107 for sun.java2d.cmm: JNI exception pending
Reviewed-by: prr, bae
! src/share/native/sun/java2d/cmm/lcms/LCMS.c
Changeset: c9c945cea665
Author:jgodinez
Date: 2013-10-15 14:24 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c9c945cea665
8015586: [macosx] Test closed/java/awt/print/PrinterJob/PrintToDir.java fails
on MacOSX
Reviewed-by: prr, jchen
!
Changeset: b164c8eb1295
Author:jgodinez
Date: 2013-10-14 09:15 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b164c8eb1295
8022536: closed/javax/print/TextFlavorTest.java fails
Reviewed-by: prr, jchen
! src/solaris/classes/sun/print/CUPSPrinter.java
!
Changeset: 2f11a00279ec
Author:jchen
Date: 2013-10-03 13:16 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2f11a00279ec
8025280: [parfait] warnings from b107 for
jdk.src.share.native.sun.java2d.loops: JNI exception pending, JNI critical
region violation
Reviewed-by: prr,
Changeset: e88d39b110dd
Author:jchen
Date: 2013-10-03 13:26 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e88d39b110dd
8025480: [parfait] JNI exception pending warnings from b107 for
jdk.src.share.native.sun.java2d
Reviewed-by: prr, jgodinez
!
Changeset: 0ed939dc4230
Author:jchen
Date: 2013-10-03 13:49 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0ed939dc4230
8025294: [parfait] JNI-related warnings from b107 for
jdk.src.solaris.native.sun.java2d.x11
Reviewed-by: prr, jgodinez
!
Approved.
Jennifer
On 8/30/2013 4:51 AM, Andrew Brygin wrote:
Hello,
could you please review a fix for CR 8022632?
Bug: http://bugs.sun.com/view_bug.do?bug_id=8022632
Webrev: http://cr.openjdk.java.net/~bae/8022632/webrev.00/
Suggested fix just makes WBMP spi canDecodeInput() method
more
Changeset: 8a041011b6e6
Author:jgodinez
Date: 2013-09-27 13:04 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8a041011b6e6
6870661: Setting a custom PrintService on a PrinterJob leads to a
PrinterException
Reviewed-by: prr, jgodinez
Contributed-by: patr...@reini.net
!
Hi Patrick,
Fix looks fine but can you send me a new webrev with the corrected typo
and move the regression tests to a new subdirectory? Also, the manual
test is reporting failure for cancel which I think should not be the
case. You may look at other manual tests on how they do this. On
Changeset: 0c950b2be7ab
Author:jgodinez
Date: 2013-08-19 11:21 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0c950b2be7ab
8022241: [macosx] [PIT] lookupPrintServices() returns one too long array
Reviewed-by: prr, jchen
!
Changeset: 2722f4000b65
Author:jgodinez
Date: 2013-08-15 11:56 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2722f4000b65
8023045: [MacOSX] PrinterIOException when printing a JComponent
Reviewed-by: bae, jchen
! src/share/classes/sun/print/PSPrinterJob.java
Hi Dan,
Fix looks good.
Jennifer
On 8/12/2013 1:48 PM, Jennifer Godinez wrote:
Hi Dan,
I will run some tests and let you know the results.
Thank you.
Jennifer
On 8/8/2013 1:14 PM, Dan Xu wrote:
Hi Phil and Jennifer,
Thanks for your suggestions!
I have updated the changes at
http
Hi Dan,
I will run some tests and let you know the results.
Thank you.
Jennifer
On 8/8/2013 1:14 PM, Dan Xu wrote:
Hi Phil and Jennifer,
Thanks for your suggestions!
I have updated the changes at
http://cr.openjdk.java.net/~dxu/8017109/webrev.00/. Please help review
and sponsor it.
-Dan
Changeset: c3b91dc2504a
Author:jgodinez
Date: 2013-08-06 14:22 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c3b91dc2504a
8021583: test/javax/print/autosense/PrintAutoSenseData.java throwing NPE
Reviewed-by: jchen, prr
! src/solaris/classes/sun/print/UnixPrintJob.java
!
Changeset: 046025f78ea8
Author:jgodinez
Date: 2013-07-30 13:01 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/046025f78ea8
8021835: Fix for 8016343 will not compile on Windows.
Reviewed-by: jchen, prr
! src/share/classes/sun/print/PSPrinterJob.java
Changeset: 467a0c21790b
Author:jgodinez
Date: 2013-07-26 15:08 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/467a0c21790b
8020208: NullPointerException at sun.print.Win32PrintService.getMediaPrintables
Reviewed-by: jchen, prr
!
Changeset: 56c6f9a9653d
Author:jgodinez
Date: 2013-07-26 15:25 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/56c6f9a9653d
8016343: [macosx] Print job goes to default printer regardless of chosen printer
Reviewed-by: jchen, prr
!
Changeset: db2e3a686cf3
Author:jchen
Date: 2013-07-24 12:40 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/db2e3a686cf3
8011709: [parfait] False positive: memory leak in
jdk/src/share/native/sun/font/layout/CanonShaping.cpp
Reviewed-by: jgodinez, prr
!
Changeset: c2e27e7a42ae
Author:jchen
Date: 2013-07-24 13:05 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c2e27e7a42ae
8005126: [parfait] #418 - #428 XRBackendNative.c Integer overflow
Reviewed-by: prr, vadim
! src/solaris/native/sun/java2d/x11/XRBackendNative.c
Changeset: dead66347eca
Author:jgodinez
Date: 2013-07-10 11:49 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/dead66347eca
8016737: After clicking on Print UNCOLLATED button, the print out come in
order 'Page 1', 'Page 2', 'Page 1'
Reviewed-by: jchen, prr
!
Hi Johny,
Please review.
Thanks.
- Jennifer
On 7/3/2013 12:43 PM, Phil Race wrote:
Approved.
-phil.
On 7/3/2013 11:02 AM, Jennifer Godinez wrote:
Hi Phil, Johny,
Please review fix for 8016737: After clicking on Print UNCOLLATED
button, the print out come in order 'Page 1', 'Page 2
Changeset: 75844b444879
Author:jchen
Date: 2013-07-03 10:22 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/75844b444879
8014497: [parfait] Potential null pointer dereference in
jdk/src/share/native/sun/java2d/cmm/lcms/cmsgamma.c
Reviewed-by: bae, prr
!
Hi Phil, Johny,
Please review fix for 8016737: After clicking on Print UNCOLLATED
button, the print out come in order 'Page 1', 'Page 2', 'Page 1'
Bug: http://bugs.sun.com/view_bug.do?bug_id=8016737
Webrev: http://cr.openjdk.java.net/~jgodinez/8016737/webrev.00/
Thank you.
Jennifer
Fix is pushed in both 8 and 7u40.
Jennifer
On 6/6/2013 1:18 PM, Phil Race wrote:
Hello,
The fix looks fine since appears to be functionally equivalent to
what I suggested in whatever was my last email.
In terms of back porting I think we literally have until Tuesday
to get it into 7u40.
Fix looks good.
Jennifer
On 06/01/2013 01:02 AM, Patrick Reinhart wrote:
Hi Phil,
As I'm now back from my holidays I changed the fix according your
suggestions:
http://reinharts.dyndns.org/8013810/v3/webrev
Can you take a look at it? I also restructured my webrev web folders
for all
Hi Phil and Andrew,
Please review the 7u backport fix of
7183520: [macosx]Unable to print out the defined page for
2D_PrintingTiger/JTablePrintPageRangesTest.
There's a minor difference compared to 8 as 7154047, a subset of 7183520
was already fixed in 7u so the code which has the same
Hi Phil and Andrew,
Please review the 7u backport fix of
8009199: Printed text become garbage on Mac OSX
File changed is identical in 8.
Bug:
http://bugs.sun.com/view_bug.do?bug_id=8009199
Webrev:
http://cr.openjdk.java.net/~jgodinez/8009199/webrev/
Thank you.
Jennifer
Hi Phil and Andrew,
Please review JDK 7 backport fix for
7158350: [macosx] Strange results of SwingUIText printing
Bug:
http://bugs.sun.com/view_bug.do?bug_id=7158350
Webrev:
http://cr.openjdk.java.net/~jgodinez/7158350/webrev.0/
Thank you.
- Jennifer
Changeset: f4ad2fa22474
Author:jgodinez
Date: 2013-05-29 09:18 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f4ad2fa22474
7183520: [macosx]Unable to print out the defined page for
2D_PrintingTiger/JTablePrintPageRangesTest.
Reviewed-by: bae, prr
!
Hi Phil and Johny,
Please review backport fix for 8012381 : [macosx] : Collation selection
ignored when printing on MacOSX
Bug:
http://bugs.sun.com/view_bug.do?bug_id=8012381
Webrev:
http://cr.openjdk.java.net/~jgodinez/8012381/
Thank you.
- Jennifer
Yes, backport to 7. The webrev shows 8 repo but file is identical in 7.
Jennifer
On 5/29/2013 1:54 PM, Phil Race wrote:
I think you mean to back port this from 8 to 7u ? Yes, looks good.
-phil.
On 5/29/2013 1:44 PM, Jennifer Godinez wrote:
Hi Phil and Johny,
Please review backport fix
Looks good.
-Jennifer
On 5/23/2013 2:26 PM, Phil Race wrote:
Jennifer Andrew,
http://cr.openjdk.java.net/~prr/8008535/
Simple fix for a printing bug dating back to JDK 7 build 08 !
-phil.
Changeset: 93de1ab38793
Author:jchen
Date: 2013-05-17 10:04 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/93de1ab38793
8003444: Fix potential NULL pointer dereference
Reviewed-by: jgodinez, prr
! src/share/native/sun/java2d/cmm/lcms/cmscgats.c
!
Changeset: 23f7ff502a89
Author:jgodinez
Date: 2013-05-07 09:32 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/23f7ff502a89
8011069: Printing: NullPointerException since jdk8 b82 showing native Page
Setup Dialog.
Reviewed-by: bae, prr
!
Changeset: f4aa34a7a44d
Author:jchen
Date: 2013-04-29 10:02 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f4aa34a7a44d
8005302: [findbugs] public methods return internal arrays; may be private
Reviewed-by: bae, prr
! src/share/classes/sun/java2d/pipe/AAShapePipe.java
Hi Phil,
I haven't confirmed this. I was about to ask for the program but now I
see it is included in the webrev. I'll let you know.
Jennifer
On 4/23/2013 9:27 AM, Phil Race wrote:
That's a Java incident number, not a JDK bug number.
JDK numbers begin with JDK-8, incident numbers begin
# guarantee(result == EXCEPTION_CONTINUE_EXECUTION) failed: Unexpected
result f
rom topLevelExceptionFilter
#
On 4/17/2013 9:49 AM, Jennifer Godinez wrote:
Thanks Anton. I will test your fix and let you know.
Jennifer
On 4/17/2013 5:53 AM, Anton Litvinov wrote:
Hello Jennifer,
Thank you very
) to be
displayed.
Thank you,
Anton
On 3/29/2013 11:26 PM, Jennifer Godinez wrote:
Hi Anton,
What printer and printer driver version did you use to test your fix?
Thanks.
Jennifer
On 3/11/2013 1:41 AM, Anton Litvinov wrote:
Hello,
Please review the following fix. This is the second reminder
message
Hi Anton,
What printer and printer driver version did you use to test your fix?
Thanks.
Jennifer
On 3/11/2013 1:41 AM, Anton Litvinov wrote:
Hello,
Please review the following fix. This is the second reminder message.
Please take into account that the original review request was sent
more
Changeset: 87c62f03bc07
Author:jgodinez
Date: 2013-03-27 12:42 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/87c62f03bc07
8010005: [parfait] Memory leak in jdk/src/macosx/native/sun/awt/CTextPipe.m
Reviewed-by: bae, prr
Contributed-by: jia-hong.c...@oracle.com
!
Looks good.
Jennifer
On 3/4/2013 8:04 AM, Andrew Brygin wrote:
Hello,
could you please review forward port of the fix for 7152608 to jdk8?
Bug: http://bugs.sun.com/view_bug.do?bug_id=7152608
Webrev: http://cr.openjdk.java.net/~bae/7152608/8/webrev.00/
The change is exactly same as for jdk7.
Changeset: 99c1f910abcc
Author:jgodinez
Date: 2013-02-22 13:20 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/99c1f910abcc
8005796: [parfait] Possible uninitialised variable at
jdk/src/share/native/sun/java2d/loops/ByteBinary1Bit.c
Reviewed-by: prr, vadim, flar
Changeset: 4b11045a9c4c
Author:jgodinez
Date: 2013-02-18 14:04 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4b11045a9c4c
8005191: [parfait] #384 sun/font/layout/LookupProcessor.cpp Null pointer
dereference
Reviewed-by: prr, vadim
Contributed-by: jia-hong.c...@oracle.com
Changeset: f6eb212081b2
Author:jgodinez
Date: 2013-02-14 14:14 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f6eb212081b2
8008173: [parfait] #1173 Uninitialised variable -- TransformHelper.cpp
Reviewed-by: prr, vadim
Contributed-by: jia-hong.c...@oracle.com
!
Hi Andrew,
Looks good.
Jennifer
On 2/1/2013 7:41 AM, Andrew Brygin wrote:
Hello Phil,
please take yet another look at updated webrev:
http://cr.openjdk.java.net/~bae/8005530/webrev.02/
Summary of changes:
- LCMS.c: unused native method getTagSize() was removed.
- mapfiles for lcms
Changeset: ad49012d10a1
Author:jgodinez
Date: 2013-02-08 11:25 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ad49012d10a1
8005129: [parfait] #1122 - #1130 native/sun/awt/medialib/mlib_Image*.c Memory
leak of pointer 'k' allocated with mlib_malloc
Reviewed-by: prr, vadim
Changeset: 37719b174e87
Author:jgodinez
Date: 2013-02-06 14:45 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/37719b174e87
8005194: [parfait] #353 sun/awt/image/jpeg/imageioJPEG.c Memory leak of pointer
'scale' allocated with calloc()
Reviewed-by: prr, vadim
Contributed-by:
Looks good.
Jennifer
On 12/21/2012 9:10 AM, Andrew Brygin wrote:
Hello Jennifer and Phil,
could you please review a fix for CR 8005402?
Bug: http://bugs.sun.com/view_bug.do?bug_id=8005402
Webrev: http://cr.openjdk.java.net/~bae/8005402/webrev.00/
This fix extends J2DBench with benchmarks for
Changeset: a988c23b8553
Author:jgodinez
Date: 2012-12-20 14:43 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a988c23b8553
7180359: Assertion in awt_Win32GraphicsDevice.cpp when running specjbb in jprt
Reviewed-by: bae, prr
! src/windows/native/sun/windows/awt_Debug.cpp
I approve the change but we need one more reviewer before pushing the
change.
Jennifer
On 12/3/2012 10:26 PM, jayashree viswanathan wrote:
On 03-12-2012 11:28 AM, jayashree viswanathan wrote:
On 13-09-2012 7:35 PM, jayashree viswanathan wrote:
Hi ,
Looking for a reviewer for a change
Hi Andrew,
Looks good.
Jennifer
On 11/26/2012 4:38 AM, Andrew Brygin wrote:
Hello,
could you please review a fix for 7124347?
This fix does not implement getRater() in ogl surfaces.
Instead, it provides a blit for custom composite, which
prepares a snapshot of the destination surface
Approved.
Jennifer
On 9/25/2012 3:30 AM, Andrew Brygin wrote:
Hello Phil, and Jennifer,
could you please review a forward port of the fix for 71242223
to jdk8?
This problem is macosx specific and was resolved in 7u4,
the the fix for some reasons was not included in the bulk
update of
Changeset: 8a64eeca4450
Author:jgodinez
Date: 2012-09-10 10:07 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8a64eeca4450
7183516: [macosx]Can't print-out the defined fonts for PrintFont_2D and
AntialiasTableTest.
Reviewed-by: bae, prr
!
Hi Andrew,
Looks good.
Jennifer
On 9/3/2012 6:53 AM, Andrew Brygin wrote:
Hello,
could you please review a backport of the fix for 6997116?
This fix prevents a class cast exception during rendering via d3d
pipeline under certain circumstances. This fix was done in early
builds of jdk8
Approved.
- Jennifer
On 9/8/2012 4:30 AM, Andrew Brygin wrote:
Hello Phil, and Jennifer,
could you please review a fix for 7181199?
The observed difference in the consumed time is caused by
SunFontManager::loadFonts(): in case of headless, it takes
much more time to complete. In fact all
Approved
On 6/14/2012 1:11 AM, Andrew Brygin wrote:
Hello Jennifer, and Phil,
could you please review a back port of the fix for 7153693 to 7u6?
The change is exactly same as for jdk8.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153693
Webrev:
Hi Andrew,
Fix looks good.
Jennifer
On 6/13/2012 1:09 PM, Phil Race wrote:
Andrew,
Seems fine. I don't know if we ever give up any measurable performance
but we need to be correct. Is fix this verified by the SQE test suite ?
If so add noreg-sqe to the bug, else try for a regression test if
Changeset: cdaadcc2c6a4
Author:jgodinez
Date: 2012-04-26 13:16 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cdaadcc2c6a4
7013850: Please change the mnemonic assignment system to avoid translation issue
Reviewed-by: prr, mfang
!
Changeset: 762661efef30
Author:jgodinez
Date: 2012-04-24 13:29 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/762661efef30
7157659: [macosx] Landscape Printing orientation doesn't work
Reviewed-by: bae, prr
! src/macosx/native/sun/awt/PrinterView.m
Hi Sean,
Changes look god.
Jennifer
Sean Chou wrote:
Hi all,
I still need one more review count, can any one help take a look ?
Thank you in advance !
-- Forwarded message --
From: *Sean Chou* zho...@linux.vnet.ibm.com
mailto:zho...@linux.vnet.ibm.com
Date: Tue, Mar
1 - 100 of 173 matches
Mail list logo
